Bug 1279637

Summary:	Data Tiering:Regression:Detach tier commit is passing when detach tier is in progress
Product:	[Community] GlusterFS	Reporter:	Dan Lambright <dlambrig>
Component:	tiering	Assignee:	Dan Lambright <dlambrig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	mainline	CC:	amukherj, bugs, dlambrig, nchilaka, sankarshan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1264441	Environment:
Last Closed:	2016-06-16 13:43:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1264441
Bug Blocks:	1278390

Description Dan Lambright 2015-11-09 22:19:14 UTC

+++ This bug was initially created as a clone of Bug #1264441 +++

when detach tier is in progress, detach tier commit must not be allowed.
This was working well previously. This means it is a regression,
Could be due to fix for bz#1259694


glusterfs-server-3.7.4-0.33.git1d02d4b.el7.centos.x86_64


Steps to Reproduce:
====================
1.create a volume, start it and attac tier to vol  and create lot of data on hot tier
2.now issue a detach-tier <vname> start
3. While it is in progress,issue a detach-tier <vname> commit

--- Additional comment from nchilaka on 2015-09-18 09:21:39 EDT ---

this wasfound during automation of qe scripts

--- Additional comment from Dan Lambright on 2015-09-30 15:36:21 EDT ---

have done a RCA on this and will begin working on a fix.

--- Additional comment from Dan Lambright on 2015-10-01 11:14:45 EDT ---

submitted fix 12272

--- Additional comment from Vijay Bellur on 2015-10-28 12:44:33 EDT ---

REVIEW: http://review.gluster.org/12272 (cluster/tier: migration daemon incorrectly signals detach tier done) posted (#3) for review on release-3.7 by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-28 16:31:24 EDT ---

REVIEW: http://review.gluster.org/12272 (cluster/tier: Disallow detach commit when detach in progress) posted (#4) for review on release-3.7 by Dan Lambright (dlambrig)

Comment 1 Atin Mukherjee 2015-11-16 06:05:17 UTC

http://review.gluster.org/#/c/12560/ posted for review

Comment 2 Vijay Bellur 2015-11-16 12:10:11 UTC

COMMIT: http://review.gluster.org/12560 committed in master by Dan Lambright (dlambrig) 
------
commit 6000e1aa344e523aa161427a0b9781e052cd4d97
Author: Dan Lambright <dlambrig>
Date:   Thu Oct 1 11:05:25 2015 -0400

    cluster/tier: Disallow detach commit when detach in progress
    
    1. Check if detach is running, disallow detach commit if so.
    2. Cleanup shutdown of tier daemon on detach: do not rerun fix-layout,
       do not send incorrect status back to glusterd.
    
    Change-Id: I97202f748773c1176396a4ffd32a4c7fa9b9c1bc
    BUG: 1279637
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/12560
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Niels de Vos 2016-06-16 13:43:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user