Bug 1280373

Summary:	deprecation messages: /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42
Product:	Red Hat CloudForms Management Engine	Reporter:	Thomas Hennessy <thenness>
Component:	Providers	Assignee:	Adam Grare <agrare>
Status:	CLOSED WORKSFORME	QA Contact:	Dave Johnson <dajohnso>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	jdeubel, jfrey, jhardy, jocarter, mfeifer, obarenbo, tcarlin
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	ems_refresh
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-23 13:16:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thomas Hennessy 2015-11-11 15:13:55 UTC

Description of problem:thousands of deprecation messages from non-UI worker processes are littering the production log.  general message form is :"called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)"


Version-Release number of selected component (if applicable):
5.5.0.9-beta2

How reproducible: initiate smartstate scans and analysis from appliance with VMware provider


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Sample of production level depracation warning messages:
=====
[----] W, [2015-11-09T03:37:54.312659 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.410926 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.505765 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.595273 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.677448 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.802443 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:54.890845 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:55.018193 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
[----] W, [2015-11-09T03:37:55.106516 #5242:5c7998]  WARN -- : DEPRECATION WARNING: numvcpus= is deprecated and will be removed from ManageIQ D-release (cpu_sockets=). (called from save_inventory at /var/www/miq/vmdb/app/models/ems_refresh/save_inventory_helper.rb:42)
=====

Comment 2 Greg Blomquist 2016-02-19 21:05:40 UTC

Adam, can you just validate that this doesn't happen anymore?

I think we cleaned all these up, but we may have missed a few.  Also, the bug indicates that it happens during smartstate, but I suspect you could reproduce this with a simple inventory collection.

If not, lean on Rich for some smart states.

Comment 3 Greg Blomquist 2016-02-19 21:24:36 UTC

*** Bug 1276666 has been marked as a duplicate of this bug. ***

Comment 4 Adam Grare 2016-02-22 14:57:35 UTC

Greg, I do not see this with current upstream doing an inventory collection.
Looking at the source at 5.5.0-beta2 we are setting the numvcpus property of hosts which would trigger that deprecation warning during an inventory refresh.

This appears to have been fixed by 15c9667fe7cd2c4ddb1d2c136c05b20d2b3a3762 which was added in 5.5.0-rc1.