Bug 1282099
| Summary: | Python3 port of python-django-admin-honeypot | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adolfo Fitoria <fitoria> | ||||||
| Component: | python-django-admin-honeypot | Assignee: | Eduardo Echeverria <echevemaster> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 24 | CC: | cstratak, echevemaster, jberan, lbalhar, mhroncok, mrunge, pviktori | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-django-admin-honeypot-1.0.0-1.fc26 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-09-07 10:51:25 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1285816, 1333770 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adolfo Fitoria
2015-11-14 22:27:15 UTC
Here's a more fleshed out report: Upstream, this software supports Python 3. Please provide a Python 3 package for Fedora. According to the Python packaging guidelines [0], software must be packaged for Python 3 if upstream supports it. The guidelines give detailed information on how to do this, and even provide an example spec file [1]. The current best practice is to provide subpackages for the two Python versions (called "Common SRPM" in the guidelines). Alternatively, if nothing depends on your Python2 package, you can just switch to Python 3 entirely. It's fine to do this in Rawhide only. If anything is unclear, or if you need any kind of assistance with the porting, you can ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy to help! [0] https://fedoraproject.org/wiki/Packaging:Python [1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Ping? No response as of yet from maintainer This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Eduardo, do you need some help with updating, or with porting to Python 3? Created attachment 1187932 [details] Update to 1.0.0 including tests and Python 3 subpackage I have prepared Python 3 patch which includes - update to version 1.0.0 - source update - tests are included now - modernized specfile with Python 3 packaging - changelog correction to avoid a following error from rpmlint: $ rpmlint python-django-admin-honeypot.spec python-django-admin-honeypot.spec: E: specfile-error warning: bogus date in %changelog: Tue Feb 22 2013 Eduardo Echeverria <echevemaster> - 0.2.4-3 0 packages and 1 specfiles checked; 1 errors, 0 warnings. The patch follows the recommendation of Matthias (bug #1311552). Sorry for the delay, I'll include your patch. thanks. Hello. Thank you for new specfile but build fails because there are missing build requires python2-coverage & python2-pytest and python3-coverage & python3-pytest for Python 3 subpackage. Also, more specific python[23]-coverage should be used in test execution command. Created attachment 1191667 [details]
Updated spec file
Hi Lumír,
thank you for the review. I attach the spec file, updated according to you guidance.
Hello. Thank you very much for the update. Specfile looks perfect to me now. If maintainer has nothing against, we can push this changes after a week. Have a nice day. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15293594 |