Bug 1282149

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Hello Raphael,

Do you need any help adding Python 3 support to the RPM?

If you need more instructions, a [guide] for porting Python-based RPMs is available.

[guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html

Hi Dominika,

I took the package because it was orphaned for some weeks and it's a dependency of backintime where I'm co-maintainer of. Currently, I do not have the time to fix bugs that got assigned to me automatically due to the owner change, could you do that instead? I can give the package to you in PkgDB.

There was support for python3 with the python3-SecretStorage subpackage since the beginning. This bug is about splitting python2 into its own subpackage according to the common example in python guidelines.
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

I am preparing a patch for this package to address all the issues. I can get it on pkgdb, but will wait for Dominika to answer first, maybe she would like to maintain it.

So here is the updated SPEC file:
https://cstratak.fedorapeople.org/python-SecretStorage.spec

And the SRPM:
https://cstratak.fedorapeople.org/python-SecretStorage-2.1.4-1.fc25.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14171996

The updates also address 1237384 and 1328216 bugzillas. Feel free to review the changes. I will push to rawhide/f24 and maybe f23 if there are no objections by tomorrow.

> %global pkgname SecretStorage

We should use srcname instead of pkgname. Otherwise, the %python_provide macro can't work correctly.

You are correct, will fix it.

SPEC: https://cstratak.fedorapeople.org/python-SecretStorage.spec

SRPM: https://cstratak.fedorapeople.org/python-SecretStorage-2.1.4-1.fc25.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14183869

python-SecretStorage-2.1.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-36b5949d94

python-SecretStorage-2.1.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-36b5949d94

# dnf install python-SecretStorage

installs still 2.1.1-3.fc24, why?

# dnf install python2-SecretStorage

installs 2.1.4-1.fc24

Maybe we miss an Obsoletes: python-SecretStorage < 2.1.4

https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

The update is still in testing repos. At the moment only the testing repositories (which are enabled by default in the beta image) provide python2-SecretStorage package. When it is pushed to the stable repositories it will (or should) work as intended.

(In reply to Charalampos Stratakis from comment #15)
> The update is still in testing repos. At the moment only the testing
> repositories (which are enabled by default in the beta image) provide
> python2-SecretStorage package. When it is pushed to the stable repositories
> it will (or should) work as intended.

# dnf install --enablerepo updates-testing python-SecretStorage
→ 2.1.1-3.fc24

Hmm.

As nothing else than backintime-qt4 is depending, and here it is python3-SecretStorage, it should be okay to go with the fix.

(In reply to Raphael Groner from comment #16)
> (In reply to Charalampos Stratakis from comment #15)
> > The update is still in testing repos. At the moment only the testing
> > repositories (which are enabled by default in the beta image) provide
> > python2-SecretStorage package. When it is pushed to the stable repositories
> > it will (or should) work as intended.
> 
> # dnf install --enablerepo updates-testing python-SecretStorage
> → 2.1.1-3.fc24
> 
> Hmm.

# dnf install dbus-python #dbus-python is not in updates-testing repos
# dnf install python-SecretStorage --disablerepo=* --enablerepo=updates-testing --refresh

And this should work properly. However if there would be an issue by the time it goes to stable repos about that, it wouldn't be a problem to just add an Obsoletes.

python-SecretStorage-2.1.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.