Bug 1286558
| Summary: | engine-setup should not depend on yum groups | |||
|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Yedidyah Bar David <didi> | |
| Component: | Setup.Core | Assignee: | Sandro Bonazzola <sbonazzo> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Gonza <grafuls> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 3.6.1 | CC: | bmcclain, bugs, didi, gklein, lveyde, pstehlik, rmartins, sbonazzo, sherold, stirabos, ylavi | |
| Target Milestone: | ovirt-3.6.2 | Keywords: | CodeChange | |
| Target Release: | 3.6.2.5 | Flags: | rule-engine:
ovirt-3.6.z+
sherold: planning_ack+ sbonazzo: devel_ack+ pstehlik: testing_ack+ |
|
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: |
Cause:
engine-setup relied on a specific yum group to define a set of additional packages to be updated.
Consequence:
If such a group was not available for any reason, these additional packages were not updated.
Fix:
engine-setup was changed to not rely on such a group and instead have this list hard-coded in it. This list can be overridden by an answer file if needed.
Result:
The list of packages to upgrade is independent of the yum repository management so they are always updated.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1286660 (view as bug list) | Environment: | ||
| Last Closed: | 2016-02-18 11:07:48 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1286660 | |||
Needs to be discussed in scrub, un-approving for now. setting requires_doc_text to '-' because we do not use it upstream, and downstream we have bug 1286660, not need to have both. as sanity tests with yum passed on this codechange moving to verify tested with rhevm-3.6.2.6-0.1.el6.noarch *** Bug 1084489 has been marked as a duplicate of this bug. *** Verified with upgrade from: ovirt-engine-3.5.6.2-1.el6.noarch to: ovirt-engine-3.6.2.6-1.el6.noarch Downgraded Otopi in between upgrades: yum downgrade ./builds/3.6/3.6.0-14/el6/noarch/otopi-1.4.0-0.0.6.master.el6ev.noarch.rpm ./builds/3.6/3.6.0-14/el6/noarch/otopi-java-1.4.0-0.0.6.master.el6ev.noarch.rpm Upgrade completed successfully with the following: ... Setup has found updates for some packages: PACKAGE: [install] ebay-cors-filter-1.0.1-0.1.ovirt.el6.noarch PACKAGE: [updated] ovirt-engine-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-backend-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-backend-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-cli-3.5.0.6-1.el6.noarch PACKAGE: [update] ovirt-engine-cli-3.6.0.2-1.el6.noarch PACKAGE: [updated] ovirt-engine-dbscripts-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-dbscripts-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-extensions-api-impl-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-extensions-api-impl-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-restapi-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-restapi-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-sdk-python-3.5.6.0-1.el6.noarch PACKAGE: [update] ovirt-engine-sdk-python-3.6.2.1-1.el6.noarch PACKAGE: [install] ovirt-engine-setup-plugin-vmconsole-proxy-helper-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-tools-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-tools-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-userportal-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-userportal-3.6.2.6-1.el6.noarch PACKAGE: [install] ovirt-engine-vmconsole-proxy-helper-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-webadmin-portal-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-webadmin-portal-3.6.2.6-1.el6.noarch PACKAGE: [updated] ovirt-engine-websocket-proxy-3.5.6.2-1.el6.noarch PACKAGE: [update] ovirt-engine-websocket-proxy-3.6.2.6-1.el6.noarch PACKAGE: [install] ovirt-engine-wildfly-8.2.1-1.el6.x86_64 PACKAGE: [install] ovirt-engine-wildfly-overlay-8.0.4-1.el6.noarch PACKAGE: [updated] ovirt-host-deploy-1.3.2-1.el6.noarch PACKAGE: [update] ovirt-host-deploy-1.4.1-1.el6.noarch PACKAGE: [updated] ovirt-host-deploy-java-1.3.2-1.el6.noarch PACKAGE: [update] ovirt-host-deploy-java-1.4.1-1.el6.noarch PACKAGE: [updated] ovirt-image-uploader-3.5.1-1.el6.noarch PACKAGE: [update] ovirt-image-uploader-3.6.0-1.el6.noarch PACKAGE: [updated] ovirt-iso-uploader-3.5.2-1.el6.noarch PACKAGE: [update] ovirt-iso-uploader-3.6.0-1.el6.noarch PACKAGE: [install] ovirt-log-collector-3.6.0-1.el6.noarch PACKAGE: [install] ovirt-vmconsole-1.0.0-1.el6.noarch PACKAGE: [install] ovirt-vmconsole-proxy-1.0.0-1.el6.noarch PACKAGE: [install] slf4j-1.7.7-1.el6.noarch PACKAGE: [updated] vdsm-jsonrpc-java-1.0.15-1.el6.noarch PACKAGE: [update] vdsm-jsonrpc-java-1.1.7-1.el6.noarch ... |
Description of problem: engine-setup currently depends on yum groups ('ovirt-engine-X.Y', 'rhevmXY' in rhevm) for installing/updating extra packages. This does not work well upstream for some time now (since 3.5.0 was released or so) and so we do not create there yum groups. Downstream it requires quite a lot of maintenance, having to create such a group and maintain it per release, in various different environments (CI, QE production), is often forgotten. We should drop this functionality, stop creating these yum groups, and instead using the existing functionality that allows doing that by adding lists of packages to be installed/updated to osetupcons.RPMDistroEnv.PACKAGES_UPGRADE_LIST . Since we do not have this group in 3.6 currently (not in upstream which is already GA, nor in downstream CI), I propose to accept this bug for 3.6. Patches to add the relevant packages were prepared, and we can drop the functionality later (in 4.0).