Bug 1286558 - engine-setup should not depend on yum groups
Summary: engine-setup should not depend on yum groups
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Setup.Core
Version: 3.6.1
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-3.6.2
: 3.6.2.5
Assignee: Sandro Bonazzola
QA Contact: Gonza
URL:
Whiteboard:
: 1084489 (view as bug list)
Depends On:
Blocks: 1286660
TreeView+ depends on / blocked
 
Reported: 2015-11-30 09:07 UTC by Yedidyah Bar David
Modified: 2016-10-31 09:03 UTC (History)
11 users (show)

Fixed In Version:
Clone Of:
: 1286660 (view as bug list)
Environment:
Last Closed: 2016-02-18 11:07:48 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-3.6.z+
sherold: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1084489 0 medium CLOSED [RFE] engine packages dependencies should be restructured 2021-02-22 00:41:40 UTC
oVirt gerrit 49105 0 'None' 'MERGED' 'packaging: setup: Require latest otopi' 2019-11-24 11:26:21 UTC
oVirt gerrit 49106 0 'None' 'MERGED' 'packaging: setup: Install/Update additional packages' 2019-11-24 11:26:21 UTC
oVirt gerrit 50966 0 'None' 'MERGED' 'packaging: setup: Install/Update additional packages' 2019-11-24 11:26:21 UTC
oVirt gerrit 50967 0 'None' 'MERGED' 'packaging: setup: Install/Update additional packages' 2019-11-24 11:26:21 UTC
oVirt gerrit 65889 0 'None' 'MERGED' 'packaging: setup: Remove engine yum group' 2019-11-24 11:26:21 UTC

Internal Links: 1084489

Description Yedidyah Bar David 2015-11-30 09:07:03 UTC
Description of problem:

engine-setup currently depends on yum groups ('ovirt-engine-X.Y', 'rhevmXY' in rhevm) for installing/updating extra packages.

This does not work well upstream for some time now (since 3.5.0 was released or so) and so we do not create there yum groups.

Downstream it requires quite a lot of maintenance, having to create such a group and maintain it per release, in various different environments (CI, QE production), is often forgotten.

We should drop this functionality, stop creating these yum groups, and instead using the existing functionality that allows doing that by adding lists of packages to be installed/updated to osetupcons.RPMDistroEnv.PACKAGES_UPGRADE_LIST .

Since we do not have this group in 3.6 currently (not in upstream which is already GA, nor in downstream CI), I propose to accept this bug for 3.6. Patches to add the relevant packages were prepared, and we can drop the functionality later (in 4.0).

Comment 1 Yaniv Lavi 2015-12-02 21:14:07 UTC
Needs to be discussed in scrub, un-approving for now.

Comment 2 Yedidyah Bar David 2016-01-11 08:22:50 UTC
setting requires_doc_text to '-' because we do not use it upstream, and downstream we have bug 1286660, not need to have both.

Comment 3 Lukas Svaty 2016-01-21 15:04:54 UTC
as sanity tests with yum passed on this codechange moving to verify
tested with rhevm-3.6.2.6-0.1.el6.noarch

Comment 4 Yedidyah Bar David 2016-01-24 10:29:28 UTC
*** Bug 1084489 has been marked as a duplicate of this bug. ***

Comment 5 Gonza 2016-01-27 16:06:31 UTC
Verified with upgrade from:
ovirt-engine-3.5.6.2-1.el6.noarch
to:
ovirt-engine-3.6.2.6-1.el6.noarch

Downgraded Otopi in between upgrades:
yum downgrade ./builds/3.6/3.6.0-14/el6/noarch/otopi-1.4.0-0.0.6.master.el6ev.noarch.rpm ./builds/3.6/3.6.0-14/el6/noarch/otopi-java-1.4.0-0.0.6.master.el6ev.noarch.rpm

Upgrade completed successfully with the following:
...
Setup has found updates for some packages:
PACKAGE: [install] ebay-cors-filter-1.0.1-0.1.ovirt.el6.noarch
PACKAGE: [updated] ovirt-engine-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-backend-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-backend-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-cli-3.5.0.6-1.el6.noarch
PACKAGE: [update] ovirt-engine-cli-3.6.0.2-1.el6.noarch
PACKAGE: [updated] ovirt-engine-dbscripts-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-dbscripts-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-extensions-api-impl-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-extensions-api-impl-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-restapi-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-restapi-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-sdk-python-3.5.6.0-1.el6.noarch
PACKAGE: [update] ovirt-engine-sdk-python-3.6.2.1-1.el6.noarch
PACKAGE: [install] ovirt-engine-setup-plugin-vmconsole-proxy-helper-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-tools-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-tools-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-userportal-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-userportal-3.6.2.6-1.el6.noarch
PACKAGE: [install] ovirt-engine-vmconsole-proxy-helper-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-webadmin-portal-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-webadmin-portal-3.6.2.6-1.el6.noarch
PACKAGE: [updated] ovirt-engine-websocket-proxy-3.5.6.2-1.el6.noarch
PACKAGE: [update] ovirt-engine-websocket-proxy-3.6.2.6-1.el6.noarch
PACKAGE: [install] ovirt-engine-wildfly-8.2.1-1.el6.x86_64
PACKAGE: [install] ovirt-engine-wildfly-overlay-8.0.4-1.el6.noarch
PACKAGE: [updated] ovirt-host-deploy-1.3.2-1.el6.noarch
PACKAGE: [update] ovirt-host-deploy-1.4.1-1.el6.noarch
PACKAGE: [updated] ovirt-host-deploy-java-1.3.2-1.el6.noarch
PACKAGE: [update] ovirt-host-deploy-java-1.4.1-1.el6.noarch
PACKAGE: [updated] ovirt-image-uploader-3.5.1-1.el6.noarch
PACKAGE: [update] ovirt-image-uploader-3.6.0-1.el6.noarch
PACKAGE: [updated] ovirt-iso-uploader-3.5.2-1.el6.noarch
PACKAGE: [update] ovirt-iso-uploader-3.6.0-1.el6.noarch
PACKAGE: [install] ovirt-log-collector-3.6.0-1.el6.noarch
PACKAGE: [install] ovirt-vmconsole-1.0.0-1.el6.noarch
PACKAGE: [install] ovirt-vmconsole-proxy-1.0.0-1.el6.noarch
PACKAGE: [install] slf4j-1.7.7-1.el6.noarch
PACKAGE: [updated] vdsm-jsonrpc-java-1.0.15-1.el6.noarch
PACKAGE: [update] vdsm-jsonrpc-java-1.1.7-1.el6.noarch
...


Note You need to log in before you can comment on or make changes to this bug.