Bug 1287080

Summary:	Review Request: perl-Test-Class-Most - Test classes the easy way
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-Class-Most-0.08-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-02 14:41:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1287121

Description Jitka Plesnikova 2015-12-01 13:15:45 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most-0.08-1.fc24.src.rpm

Description:
When people write test classes with the excellent Test::Class, you often see the following at the top of the code:

  package Some::Test::Class;

  use strict;
  use warnings;
  use base 'My::Test::Class';
  use Test::More;
  use Test::Exception;

  # and then the tests ...

With the module, you can do this:

  use Test::Class::Most parent => 'My::Test::Class';


Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-12-01 14:30:39 UTC

* Consider a better description.  One without code.
  E.g. something along the lines of `reduce boilerplate when writing
  tests based on Test::Class'.

* Missing a BR: lib, t/test_class_load.t:9

* Add a version constraint to the explicitly required Test::Most, 0.31+.

* Also require Test::Class 0.38+ and filter out the underspecified dependency.

* Use a lowercase `c' in `classes' in your summary.
  Alternatively, insert a double colon like `Test::Classes the easy way'.

No other issues.

Comment 2 Jitka Plesnikova 2015-12-02 08:42:39 UTC

(In reply to Petr Šabata from comment #1)
> * Consider a better description.  One without code.
>   E.g. something along the lines of `reduce boilerplate when writing
>   tests based on Test::Class'.
Updated

> * Missing a BR: lib, t/test_class_load.t:9
Added

> * Add a version constraint to the explicitly required Test::Most, 0.31+.
> * Also require Test::Class 0.38+ and filter out the underspecified
> dependency.
Added
 
> * Use a lowercase `c' in `classes' in your summary.
>   Alternatively, insert a double colon like `Test::Classes the easy way'.
Updated

The updated files are on the same link.

Comment 3 Petr Šabata 2015-12-02 10:12:56 UTC

Ack, all four addressed.  Approving.

Comment 4 Gwyn Ciesla 2015-12-02 14:28:19 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Test-Class-Most

Comment 5 Jitka Plesnikova 2015-12-02 14:41:43 UTC

Thank you for the review and the repository.