Bug 1287080 - Review Request: perl-Test-Class-Most - Test classes the easy way
Review Request: perl-Test-Class-Most - Test classes the easy way
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1287121
  Show dependency treegraph
 
Reported: 2015-12-01 08:15 EST by Jitka Plesnikova
Modified: 2015-12-02 09:41 EST (History)
2 users (show)

See Also:
Fixed In Version: perl-Test-Class-Most-0.08-1.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-12-02 09:41:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
psabata: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2015-12-01 08:15:45 EST
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-Class-Most/perl-Test-Class-Most-0.08-1.fc24.src.rpm

Description:
When people write test classes with the excellent Test::Class, you often see the following at the top of the code:

  package Some::Test::Class;

  use strict;
  use warnings;
  use base 'My::Test::Class';
  use Test::More;
  use Test::Exception;

  # and then the tests ...

With the module, you can do this:

  use Test::Class::Most parent => 'My::Test::Class';


Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Šabata 2015-12-01 09:30:39 EST
* Consider a better description.  One without code.
  E.g. something along the lines of `reduce boilerplate when writing
  tests based on Test::Class'.

* Missing a BR: lib, t/test_class_load.t:9

* Add a version constraint to the explicitly required Test::Most, 0.31+.

* Also require Test::Class 0.38+ and filter out the underspecified dependency.

* Use a lowercase `c' in `classes' in your summary.
  Alternatively, insert a double colon like `Test::Classes the easy way'.

No other issues.
Comment 2 Jitka Plesnikova 2015-12-02 03:42:39 EST
(In reply to Petr Šabata from comment #1)
> * Consider a better description.  One without code.
>   E.g. something along the lines of `reduce boilerplate when writing
>   tests based on Test::Class'.
Updated

> * Missing a BR: lib, t/test_class_load.t:9
Added

> * Add a version constraint to the explicitly required Test::Most, 0.31+.
> * Also require Test::Class 0.38+ and filter out the underspecified
> dependency.
Added
 
> * Use a lowercase `c' in `classes' in your summary.
>   Alternatively, insert a double colon like `Test::Classes the easy way'.
Updated

The updated files are on the same link.
Comment 3 Petr Šabata 2015-12-02 05:12:56 EST
Ack, all four addressed.  Approving.
Comment 4 Gwyn Ciesla 2015-12-02 09:28:19 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Test-Class-Most
Comment 5 Jitka Plesnikova 2015-12-02 09:41:43 EST
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.