Bug 1287121 - Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components
Summary: Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1287080
Blocks: 1288541
TreeView+ depends on / blocked
 
Reported: 2015-12-01 14:40 UTC by Jitka Plesnikova
Modified: 2015-12-11 11:22 UTC (History)
2 users (show)

Fixed In Version: perl-Mason-Tidy-2.57-2.fc24
Clone Of:
Environment:
Last Closed: 2015-12-11 11:22:57 UTC
Type: ---
Embargoed:
psabata: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-12-01 14:40:19 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy-2.57-1.fc24.src.rpm

Description:
Mason::Tidy is the engine used by masontidy. You can call this API from
your own program instead of executing masontidy.

masontidy tidies Mason 1 and Mason 2 components, using perltidy to format
the Perl code that can be embedded in various places in the component.
masontidy does not (yet) attempt to tidy the HTML or other non-Perl content
in a component.

Fedora Account System Username: jplesnik

Comment 1 Upstream Release Monitoring 2015-12-08 08:02:14 UTC
jplesnik's scratch build of perl-Mason-Tidy-2.57-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12108654

Comment 2 Petr Šabata 2015-12-08 16:33:34 UTC
* Hmm, the test classes, unfortunatelly packaged in the Mason::Tidy::t
  namespace could be subpackaged.  Or excluded completely.  The module
  doesn't use them, neither does the script.

* If you decide to exclude the test classes, you can drop the explicit
  runtime dependencies.

* Add version constraints for Method::Signatures::Simple and Moo.
  For both buildtime and runtime deps.

* The %license compatibility hack isn't really needed as this won't work
  in EPEL anyway (too old EU::MM).

Comment 3 Jitka Plesnikova 2015-12-09 15:10:25 UTC
I excluded the test modules. Updated files are here:

Spec URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Mason-Tidy/perl-Mason-Tidy-2.57-2.fc24.src.rpm

Comment 4 Petr Šabata 2015-12-09 15:44:46 UTC
Okay, better.

Approving.

Comment 5 Gwyn Ciesla 2015-12-10 15:26:20 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Mason-Tidy

Comment 6 Jitka Plesnikova 2015-12-11 11:22:57 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.