Bug 129014
| Summary: | Rebuilding of sed always fails | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | sed | Assignee: | Jakub Jelinek <jakub> |
| Status: | CLOSED RAWHIDE | QA Contact: | Ben Levenson <benl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Keywords: | EasyFix |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 4.1.2-4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-10-08 11:25:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 123268 | ||
The LANG problem fixed differently (and submitted upstream) in 4.1.2-4. I'm not going to change the requirements on glibc (in fact I have added even a Requires as well), as there were too many regex bugs in earlier glibc releases. For those glibcs you should probably remove --without-included-regex, but the Fedora rpms really want to use it. I still have to comment your part about the glibc requirement: I'm able to rebuild 4.1.2-4 against a glibc (2.3.2-11.9) out of Red Hat Linux 9 for example (and everything is working without restrictions), so I think the requirement to such a new glibc is just foobar...if you think you need to require a actual glibc, 2.3.2-27 (not 2.3.3-27!) is absolutely more than enough... If you look at glibc ChangeLog between 2.3.2-27.* and 2.3.3-27, there were more than 100 separate changes to regex code, many of them fixing really serious bugs. |
Description of problem: Rebuilding of sed will always fail, if the LANG environment variable isn't set to "C". Version-Release number of selected component (if applicable): sed-4.1.1-1 How reproducible: Everytime, see below. Steps to Reproduce: 1. export LANG=de_DE@euro 2. rpmbuild -ba sed.spec 3. Die with an error at "make check" (1 test is not passed) Well, the reason is, that there a sed output is compared, and a German and a English localized output aren't the same *hmpf* Actual results: Here's a diff from what is working for me: --- snipp --- --- sed.spec 2004-07-08 15:53:51.000000000 +0200 +++ sed.spec.rsc 2004-08-03 01:53:02.000000000 +0200 @@ -13,7 +13,7 @@ Prefix: %{_prefix} Buildroot: %{_tmppath}/%{name}-root # Make sure glibc regex has all fixes we need -BuildRequires: glibc >= 2.3.3-27, glibc-devel >= 2.3.3-27 +BuildRequires: glibc >= 2.3.2-27, glibc-devel >= 2.3.2-27 %description The sed (Stream EDitor) editor is a stream or batch (non-interactive) @@ -30,7 +30,7 @@ make %{_smp_mflags} echo ====================TESTING========================= -make check +LANG=C make check echo ====================TESTING END===================== %install @@ -60,6 +60,10 @@ %{_mandir}/man*/* %changelog +* Tue Aug 03 2004 Robert Scheck <redhat> +- changed requirement to glibc and glibc-devel +- set LANG=C before make check to avoid problems + * Thu Jul 8 2004 Jakub Jelinek <jakub> 4.1.1-1 - update to 4.1.1 --- snapp --- Expected results: Use of the suggested changes ;-) Additional info: BTW, glibc 2.3.2-27 is even much enough, we don't need to require 2.3.3-27, I tested rebuilding of sed against glibc of Red Hat Linux 9 - and it works fine. Maybe we should request the build arch i686 of glibc, because rebuilding against a i386 glibc will always fail. The strange requirement to a very recent glibc was (wrongly) introduced after bug #123043 and corrected by me soon, but still ignored - please fix this also :-(