Bug 1290995
| Summary: | Review Request: python-visionegg-quest - QUEST algorithm for finding threshold | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | igor.raits, package-review, sanjay.ankur, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-12 02:13:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941, 1280141 | ||
|
Description
Igor Gnatenko
2015-12-12 15:16:19 UTC
+ license is OK (BSD)
+ license file is missing, but the only source file has a prominent license header
+ latest version (upstream is semi-dead, but I think it doesn't really mean much for scientific software)
+ new python packaging template is used
+ provides/requires are OK
+ builds and install OK
+ no scriptlets
+ fedora review is happy
Rpmlint
-------
Checking: python2-visionegg-quest-1.1-1.fc24.noarch.rpm
python3-visionegg-quest-1.1-1.fc24.noarch.rpm
python-visionegg-quest-1.1-1.fc24.src.rpm
python2-visionegg-quest.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/Quest.py 644 /usr/bin/env
python3-visionegg-quest.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/Quest.py 644 /usr/bin/env
I guess you could fix that.
python2-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/__pycache__/Quest.cpython-35.opt-1.pyc
3 packages and 0 specfiles checked; 2 errors, 3 warnings.
Package is APPROVED.
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-visionegg-quest Hiya, There are no builds for the package. I can build for the current releases if you add the package to the neuro-sig src.fp.org group. Cheers, Ankur Unfortunately I don't have time to work on these review requests anymore, sorry. Please give the neurofedora packager group commit access to this and one of us will build and update it. Thanks Imported, being built now. python-visionegg-quest-1.1-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2488fa18c6 python-visionegg-quest-1.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f5a8ffb9aa python-visionegg-quest-1.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c43103b9f7 python-visionegg-quest-1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f5a8ffb9aa python-visionegg-quest-1.1-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2488fa18c6 python-visionegg-quest-1.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c43103b9f7 python-visionegg-quest-1.1-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. python-visionegg-quest-1.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. python-visionegg-quest-1.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |