Bug 1290995 - Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
Status: POST
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
Depends On:
Blocks: fedora-neuro python-psychopy
  Show dependency treegraph
Reported: 2015-12-12 10:16 EST by Igor Gnatenko
Modified: 2016-08-15 11:01 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Igor Gnatenko 2015-12-12 10:16:19 EST
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-visionegg-quest.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-visionegg-quest-1.1-1.fc24.src.rpm
Description: QUEST algorithm for finding threshold.
Fedora Account System Username: ignatenkobrain
Comment 1 Zbigniew Jędrzejewski-Szmek 2015-12-12 22:00:50 EST
+ license is OK (BSD)
+ license file is missing, but the only source file has a prominent license header
+ latest version (upstream is semi-dead, but I think it doesn't really mean much for scientific software)
+ new python packaging template is used
+ provides/requires are OK
+ builds and install OK
+ no scriptlets
+ fedora review is happy

Checking: python2-visionegg-quest-1.1-1.fc24.noarch.rpm
python2-visionegg-quest.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/Quest.py 644 /usr/bin/env
python3-visionegg-quest.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/Quest.py 644 /usr/bin/env
I guess you could fix that.

python2-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: no-documentation
python3-visionegg-quest.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/__pycache__/Quest.cpython-35.opt-1.pyc
3 packages and 0 specfiles checked; 2 errors, 3 warnings.

Package is APPROVED.
Comment 2 Mike McCune 2016-03-28 19:47:57 EDT
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions
Comment 3 Gwyn Ciesla 2016-08-15 11:01:35 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-visionegg-quest

Note You need to log in before you can comment on or make changes to this bug.