Bug 1291970

Summary: Data Tiering: new set of gluster v tier commands not working as expected
Product: [Community] GlusterFS Reporter: hari gowtham <hgowtham>
Component: tieringAssignee: hari gowtham <hgowtham>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: high Docs Contact:
Priority: urgent    
Version: 3.7.6CC: bugs, dlambrig, nchilaka, sankarshan
Target Milestone: ---Keywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1288517 Environment:
Last Closed: 2016-04-19 07:51:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1283940, 1288517    
Bug Blocks:    

Comment 1 Vijay Bellur 2015-12-16 05:28:15 UTC
REVIEW: http://review.gluster.org/12976 (tier/glusterd : making new tier detach command throw warning) posted (#1) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 2 Vijay Bellur 2015-12-16 08:49:40 UTC
REVIEW: http://review.gluster.org/12976 (tier/glusterd : making new tier detach command throw warning) posted (#2) for review on release-3.7 by hari gowtham (hari.gowtham005)

Comment 3 Vijay Bellur 2015-12-16 17:28:33 UTC
COMMIT: http://review.gluster.org/12976 committed in release-3.7 by Dan Lambright (dlambrig) 
------
commit 5f6baf2cb061fd32a35bff2081b8ba966871e39d
Author: hari gowtham <hgowtham>
Date:   Fri Dec 4 18:34:36 2015 +0530

    tier/glusterd : making new tier detach command throw warning
    
            back port of : http://review.gluster.org/#/c/12883/
    
    For detach tier, the validation was done using the string "detach-tier"
    but the new commands used has the string "tier". Making the string use
    "tier" to compare, creates problem as the tier status and tier detach
    have the keyword "tier". So tier detach and tier status were separated.
    and strtok was used to prevent the condition from passing when the
    volume name has a substring of "tier". (only the second word from the
    string is got and checked if the feature is tier).
    
    Problem: new detach tier command doesnt throw warnings like
    "not a tier volume" or " detach tier not started" respectively
    instead it prints empty output.
    
    Fix: while validate the volume is checked if its a tiered volume
    if yes it is checked if the detach tier is started, else a warning
    is thrown respectively.
    
    >Change-Id: I94246d53b18ab0e9406beaf459eaddb7c5b766c2
    >BUG: 1288517
    >Signed-off-by: hari gowtham <hgowtham>
    >Reviewed-on: http://review.gluster.org/12883
    >Tested-by: NetBSD Build System <jenkins.org>
    >Tested-by: Gluster Build System <jenkins.com>
    >Reviewed-by: Atin Mukherjee <amukherj>
    
    Change-Id: I1ac3b6baaec644dbc2025085a7f17abd56ba169d
    BUG: 1291970
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: http://review.gluster.org/12976
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>

Comment 4 Kaushal 2016-04-19 07:51:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report.

glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user