Bug 1297499

Summary: CF 3.2: Automation code throwing "0x000... is recycled object" exceptions
Product: Red Hat CloudForms Management Engine Reporter: John Prause <jprause>
Component: AutomateAssignee: mkanoor
Status: CLOSED ERRATA QA Contact: Milan Falešník <mfalesni>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 5.4.0CC: cpelland, dajohnso, gmccullo, james.beal, jhardy, jocarter, mfeifer, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.3   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.5.3.2 Doc Type: Bug Fix
Doc Text:
Previously, the CloudForms Management Engine used a custom mechanism to cache objects sent as references to the Automate methods. However, some of the objects were not cached by the mechanism, resulting in Distributed Ruby (DRb) recycled object errors. DRb has a built-in caching mechanism based on TimerIdConv, so this release of Red Hat CloudForms will use DRb's caching mechanism instead to avoid these errors.
Story Points: ---
Clone Of: 1297097 Environment:
Last Closed: 2016-04-13 18:41:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1297097, 1297952    
Bug Blocks:    

Comment 3 CFME Bot 2016-02-10 19:53:48 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=eb36c3a6049ceaa2b3bad6e33e837ee93f74c395

commit eb36c3a6049ceaa2b3bad6e33e837ee93f74c395
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Thu Jan 14 17:09:23 2016 -0500
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Mon Jan 18 17:03:21 2016 -0500

    Use DRb's builtin caching mechanism
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1297499
    
    Previously we have been using our own caching mechanism to
    cache objects sent as references to the Automate Methods. We have
    gotten DRb recycled object errors, since some of the objects which
    were sent as references were not being cached.
    DRb has a builtin caching mechanism based on TimerIdConv, which
    we are starting to use in this PR.
    
    Conflicts:
    	spec/lib/miq_automation_engine/miq_ae_service_spec.rb

 lib/miq_automation_engine/engine/miq_ae_method.rb     | 8 ++++++++
 lib/miq_automation_engine/engine/miq_ae_service.rb    | 2 +-
 spec/lib/miq_automation_engine/miq_ae_service_spec.rb | 9 ---------
 3 files changed, 9 insertions(+), 10 deletions(-)

Comment 4 CFME Bot 2016-02-10 19:54:37 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=67e439f3b408f4c393a3e98668c702a5240ada13

commit 67e439f3b408f4c393a3e98668c702a5240ada13
Merge: cecc8aa eb36c3a
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Feb 10 14:25:46 2016 -0500
Commit:     Greg McCullough <gmccullo>
CommitDate: Wed Feb 10 14:25:46 2016 -0500

    Merge branch 'bugzilla_1297499_5_5_z' into '5.5.z'
    
    Use DRb's builtin caching mechanism
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1297499
    
    Previously we have been using our own caching mechanism to
    cache objects sent as references to the Automate Methods. We have
    gotten DRb recycled object errors, since some of the objects which
    were sent as references were not being cached.
    DRb has a builtin caching mechanism based on TimerIdConv, which
    we are starting to use in this PR.
    
    Conflicts:
    	spec/lib/miq_automation_engine/miq_ae_service_spec.rb
    
    Not a clean cherry pick for the above file, tests were being removed which didn't exist in 5.5
    Original PR https://github.com/ManageIQ/manageiq/pull/6190
    Only one commit from the PR has been used
    
    See merge request !727

 lib/miq_automation_engine/engine/miq_ae_method.rb     | 8 ++++++++
 lib/miq_automation_engine/engine/miq_ae_service.rb    | 2 +-
 spec/lib/miq_automation_engine/miq_ae_service_spec.rb | 9 ---------
 3 files changed, 9 insertions(+), 10 deletions(-)

Comment 5 Greg McCullough 2016-02-10 20:23:48 UTC
*** Bug 1304859 has been marked as a duplicate of this bug. ***

Comment 7 Milan Falešník 2016-03-31 15:12:45 UTC
Checked in 5.5.3.2. After discussion with mkanoor I used the script from [1] which I ran about a dozen times and no error ever happened. The provisioning also works so ...

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1284573

Comment 9 errata-xmlrpc 2016-04-13 18:41:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:0616