Hide Forgot
Created attachment 1116346 [details] Fix Please replace the enclosed 2 files into the vmdb directory
Merge Request http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/731 Pending to be merged
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a6890159511fda0773ed8dcd17402117df6c89f9 commit a6890159511fda0773ed8dcd17402117df6c89f9 Merge: 40a99c4 0945d50 Author: Greg McCullough <gmccullo> AuthorDate: Tue Feb 9 17:30:01 2016 -0500 Commit: Greg McCullough <gmccullo> CommitDate: Tue Feb 9 17:30:01 2016 -0500 Merge branch 'bugzilla_1297952_5_4_z' into '5.4.z' Use DRb's builtin caching mechanism https://bugzilla.redhat.com/show_bug.cgi?id=1297952 Previously we have been using our own caching mechanism to cache objects sent as references to the Automate Methods. We have gotten DRb recycled object errors, since some of the objects which were sent as references were not being cached. DRb has a builtin caching mechanism based on TimerIdConv, which we are starting to use in this PR. Original PR https://github.com/ManageIQ/manageiq/pull/6190 Not a clean cherry-pick, the spec file had conflict when applying the patch because of old vmdb directory in 5.4 See merge request !731 vmdb/lib/miq_automation_engine/engine/miq_ae_method.rb | 8 ++++++++ vmdb/lib/miq_automation_engine/engine/miq_ae_service.rb | 2 +- .../spec/lib/miq_automation_engine/miq_ae_service_spec.rb | 15 --------------- 3 files changed, 9 insertions(+), 16 deletions(-)
This is very difficult to recreate, because it depends on when the Garbage Collector ran on the Engine side and free'ed the object for which the automate method is still holding on to the handle and tries to access it. I think we should just test the functionality and make sure it doesn't break.
Checked in 5.4.5.2. After discussion with mkanoor I used the script from [1] which I ran about a dozen times and no error ever happened. The provisioning also works so ... [1] https://bugzilla.redhat.com/show_bug.cgi?id=1284573
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0171.html