Bug 1301030

Summary:	[Snapshot]: Snapshot restore stucks in post validation.
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.7.7	CC:	asengupt, bugs, rjoseph, sraj, storage-qa-internal
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1300979	Environment:
Last Closed:	2016-04-19 07:20:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1277414, 1300979
Bug Blocks:

Comment 1 Vijay Bellur 2016-02-29 11:48:33 UTC

REVIEW: http://review.gluster.org/13548 (snapshot: Fix parent volinfo corruption in snapshot restore) posted (#1) for review on release-3.7 by Avra Sengupta (asengupt)

Comment 2 Vijay Bellur 2016-03-11 08:07:15 UTC

COMMIT: http://review.gluster.org/13548 committed in release-3.7 by Rajesh Joseph (rjoseph) 
------
commit 7ece0b7b04059f79e25cd7bf44218eb4688dd8e3
Author: Avra Sengupta <asengupt>
Date:   Fri Jan 22 16:59:53 2016 +0530

    snapshot: Fix parent volinfo corruption in snapshot restore
    
        Backport of http://review.gluster.org/#/c/13282/
    
    Remove parent_volinfo irrespective of success or failure
    of glusterd_lvm_snapshot_remove(). This prevents the
    duplication of the volinfo after the execution of
    glusterd_snapshot_restore().
    
    When commit fails on originator node, we don't perform
    commit on the other nodes, as a result we don't have a
    backup of /var/lib/glusterd/vols/<volname> in the
    GLUSTERD_TRASH in other nodes. But in the postvalidate
    we try to restore from GLUSTED_TRASH and end up cleaning
    up /var/lib/glusterd/vols/<volname>. Hence moved
    glusterd_snapshot_backup_vol() from commit to prevalidate,
    so that the backup is always available when a cleanup is
    needed.
    
    Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
    BUG: 1301030
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/13282
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>
    (cherry picked from commit 3f78b6b3dc6376945a1b1a7c4af16103901ab746)
    Reviewed-on: http://review.gluster.org/13548

Comment 3 Kaushal 2016-04-19 07:20:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user