Bug 1300979 - [Snapshot]: Snapshot restore stucks in post validation.
Summary: [Snapshot]: Snapshot restore stucks in post validation.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: mainline
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard:
Depends On: 1277414
Blocks: 1301030
TreeView+ depends on / blocked
 
Reported: 2016-01-22 09:23 UTC by Avra Sengupta
Modified: 2016-06-16 13:55 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1277414
: 1301030 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:55:37 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Vijay Bellur 2016-01-22 12:17:02 UTC
REVIEW: http://review.gluster.org/13282 (snapshot: Fix parent volinfo corruption in snapshot restore) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 2 Vijay Bellur 2016-02-29 06:12:57 UTC
COMMIT: http://review.gluster.org/13282 committed in master by Rajesh Joseph (rjoseph) 
------
commit 3f78b6b3dc6376945a1b1a7c4af16103901ab746
Author: Avra Sengupta <asengupt>
Date:   Fri Jan 22 16:59:53 2016 +0530

    snapshot: Fix parent volinfo corruption in snapshot restore
    
    Remove parent_volinfo irrespective of success or failure
    of glusterd_lvm_snapshot_remove(). This prevents the
    duplication of the volinfo after the execution of
    glusterd_snapshot_restore().
    
    When commit fails on originator node, we don't perform
    commit on the other nodes, as a result we don't have a
    backup of /var/lib/glusterd/vols/<volname> in the
    GLUSTERD_TRASH in other nodes. But in the postvalidate
    we try to restore from GLUSTED_TRASH and end up cleaning
    up /var/lib/glusterd/vols/<volname>. Hence moved
    glusterd_snapshot_backup_vol() from commit to prevalidate,
    so that the backup is always available when a cleanup is
    needed.
    
    Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
    BUG: 1300979
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/13282
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Niels de Vos 2016-06-16 13:55:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.