Bug 1303973

Summary: ovirt-system-tests: ovirt engine installation fails because of wrong answer in the answer file
Product: [oVirt] ovirt-engine Reporter: Yaniv Kaul <ykaul>
Component: Setup.CoreAssignee: Yaniv Kaul <ykaul>
Status: CLOSED UPSTREAM QA Contact: Pavel Stehlik <pstehlik>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.6.3CC: bugs, dcaroest, didi
Target Milestone: ---Keywords: Automation, CodeChange
Target Release: ---Flags: rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1302045 Environment:
Last Closed: 2016-03-24 18:18:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: External RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaniv Kaul 2016-02-02 15:05:14 UTC 
+++ This bug was initially created as a clone of Bug #1302045 +++

Description of problem:
In basic_suite_3.6/engine-answer-file.conf , the value
OSETUP_RPMDISTRO/enableUpgrade=none:None
Should be:
OSETUP_RPMDISTRO/enableUpgrade=bool:False

Version-Release number of selected component (if applicable):
5a2c9e79d8bf15581242075c5eb53b9b34f5ae96

How reproducible:
Always - though I'm not sure how it worked so far!

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-01-26 18:12:16 IST ---

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-01-26 18:12:16 IST ---

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-01-26 18:13:04 IST ---

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-01-26 18:13:04 IST ---

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-01-26 18:13:26 IST ---

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 1 Yaniv Kaul 2016-02-02 15:07:00 UTC 
The real issue is that we did not test the success of the installation.
Proposed patch to the engine installation test:
diff --git a/basic_suite_3.6/test-scenarios/001_initialize_engine.py b/basic_suite_3.6/test-scenarios/001_initialize_engine.py
index 3347a1e..bc950ce 100644
--- a/basic_suite_3.6/test-scenarios/001_initialize_engine.py
+++ b/basic_suite_3.6/test-scenarios/001_initialize_engine.py
@@ -35,9 +35,16 @@ def test_initialize_engine(prefix):
         '/tmp/answer-file',
     )
 
-    engine.ssh(
+    result = engine.ssh(
         [
             'engine-setup',
             '--config-append=/tmp/answer-file',
         ],
     )
+
+    testlib.assert_true_within_short(
+        lambda: False if result != 0 else True
+    )
+    testlib.assert_true_within_long(
+        lambda: engine.service('ovirt-engine').alive()
+    )


David - where should I send this patch to?
Comment 2 Yedidyah Bar David 2016-02-02 15:16:08 UTC 
(In reply to Yaniv Kaul from comment #0)
> How reproducible:
> Always - though I'm not sure how it worked so far!

A wild guess: Because of bug 1301902
Comment 3 Yaniv Kaul 2016-02-03 17:50:02 UTC 
The above code in comment 1 is a bit flawed - should check for result.code value.
Comment 4 David Caro 2016-02-22 12:15:18 UTC 
Replied by email