Bug 1303995
| Summary: | SMB: SMB crashes with AIO enabled on reads + vers=3.0 | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | rjoseph | |
| Component: | gluster-smb | Assignee: | rjoseph | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | urgent | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | annair, asrivast, bturner, bugs, byarlaga, ndevos, nlevinki, rcyriac, rhs-smb, rjoseph, sankarshan, sbhaloth, storage-qa-internal | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1302901 | |||
| : | 1311578 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 13:56:34 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1302901, 1311146 | |||
| Bug Blocks: | 1311578 | |||
|
Comment 1
Vijay Bellur
2016-02-02 16:32:33 UTC
REVIEW: http://review.gluster.org/13340 (libgfapi: fd close is not correctly handled for async fop) posted (#2) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#3) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#4) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#5) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#6) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#7) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#8) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#9) for review on master by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13340 (libgfapi: glfd close is not correctly handled for async fop) posted (#10) for review on master by Rajesh Joseph (rjoseph) COMMIT: http://review.gluster.org/13340 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 88d772c05c45c467bfccebfc51f6a0e0ea9ca287 Author: Rajesh Joseph <rjoseph> Date: Tue Feb 2 04:22:04 2016 +0530 libgfapi: glfd close is not correctly handled for async fop There is chance that before the async fop is complete client can send a close. libgfapi destroys glfd on close. Therefore it can lead to crash or unexpected behaviour when the pening fop reaches libgfapi layer. Currently we don't provide any api to cancel these outstanding fops neither we check if the glfd is already closed or not. Therefore as a fix provided refcount for glfd. Each fop (sync or async) will take a ref and once the fop is complete it will unref the refcount. We should not call the registered callback function if glfd is already closed. To achieve this we maintain state of glfd so that we can safely take a call if the fd is closed or not. Change-Id: Ibe71b2225312db3f1be66b244fcf8826c70c357d BUG: 1303995 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/13340 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana> NetBSD-regression: NetBSD Build System <jenkins.org> Bug 1311146 reports a regression that was introduced with this change. http://review.gluster.org/13666 fixes regression reported by Bug 1311146. This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |