| Summary: | Review Request: ctk - the Common Toolkit for biomedical imaging | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dmitry Mikhirev <mikhirev> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-06 22:20:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Dmitry Mikhirev
2016-02-02 21:17:41 UTC
Is it really worth the trouble to split the plugin-framework and dicom and widgets subpackages? There're couple hundred kb each. Summary is not very useful. Maybe: Summary: Library for medical image analysis, surgical navigation, and related purposes Doc subpackage must be noarch! + license is acceptable (ASL 2) + license file is present, %license is used + package name follows guidelines + provides/requires look OK + scriptlets look OK + dependencies between subpackages look OK + latest version rpmlint: ctk-devel.i686: W: no-documentation ctk-dicom.i686: W: no-documentation ctk-plugin-framework.i686: W: no-documentation ctk-widgets.i686: W: spelling-error Summary(en_US) biomedical -> bio medical, bio-medical, medical ctk-widgets.i686: W: spelling-error %description -l en_US biomedical -> bio medical, bio-medical, medical ctk-widgets.i686: W: shared-lib-calls-exit /usr/lib/libCTKWidgets.so.0.1.0 exit ctk-widgets.i686: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 7 warnings. All OK. Package is APPROVED. Please fix the noarch issue and the summary. The summary as specified in the bug title is also OK. Thank you for the review!
> Is it really worth the trouble to split the plugin-framework and dicom and widgets subpackages? There're couple hundred kb each.
Yes, but e. g. dicom subpackage depends on dcmtk that is sensibly bigger.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ctk |