Bug 1309209

Summary: clone creation with older names in a system fails
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Shashank Raj <sraj>
Component: snapshotAssignee: Avra Sengupta <asengupt>
Status: CLOSED ERRATA QA Contact: Anil Shah <ashah>
Severity: high Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: amukherj, asengupt, ashah, asriram, asrivast, mzywusko, nlevinki, rcyriac, rhinduja, rhs-bugs, rjoseph, sankarshan, storage-doc, storage-qa-internal
Target Milestone: ---Keywords: Reopened, ZStream
Target Release: RHGS 3.3.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8.4-19 Doc Type: Bug Fix
Doc Text:
The names and locations of previously cloned and deleted volumes were not cleaned up correctly. This meant that creating a clone with the same name as a previously deleted clone failed with a 'Commit failed' message. Cleanup is now handled correctly and the same name can be used for a clone in this situation.
Story Points: ---
Clone Of:
: 1387160 (view as bug list) Environment:
Last Closed: 2017-09-21 04:25:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1268895, 1387160, 1417147    

Description Shashank Raj 2016-02-17 08:18:53 UTC
Description of problem:

Whenever we are creating a clone with a name that's already been a part of a system as cloned volume before (but its deleted now), it fails with "Commit failed" message. For this to work properly, user need to remove the entries of older cloned volume from /run/gluster/snaps and and unmount it.

Document URL: 

Section Number and Name: 

Describe the issue:

1.Create a clone with a name that was already a part of the system (but deleted now). However its entries can be seen under /run/gluster/snaps and it will be mounted.
2.this creation fails with commit failed message.
3.Remove the cloned volume entries from /run/gluster/snaps and unmount the clone.
4.Try the clone creation again with the same name and it should pass after removing the entries. 

Suggestions for improvement: 

Additional information:

Comment 3 Avra Sengupta 2016-02-19 08:04:56 UTC
Thanks Laura. It's perfect.

Comment 5 Avra Sengupta 2016-07-14 09:21:51 UTC
The issue is same as 1273722 and will be fixed as part of 1273722

*** This bug has been marked as a duplicate of bug 1273722 ***

Comment 7 Avra Sengupta 2016-10-18 06:21:19 UTC
This has been marked as duplicate by mistake. This needs to be fixed.

Comment 8 Avra Sengupta 2016-10-20 09:32:04 UTC
Patch posted upstream master : http://review.gluster.org/15683

Comment 10 Avra Sengupta 2016-12-23 09:41:38 UTC
*** Bug 1408386 has been marked as a duplicate of this bug. ***

Comment 13 Atin Mukherjee 2017-03-24 08:43:33 UTC
downstream patch : https://code.engineering.redhat.com/gerrit/#/c/101285

Comment 15 Anil Shah 2017-05-02 10:05:06 UTC
[root@rhs-arch-srv1 yum.repos.d]# gluster snapshot clone clone1 snap0
snapshot clone: success: Clone clone1 created successfully
[root@rhs-arch-srv1 yum.repos.d]# gluster v list
clone1
gluster_shared_storage
newvolume
vol0
vol1
[root@rhs-arch-srv1 yum.repos.d]# gluster v start clone1
volume start: clone1: success
[root@rhs-arch-srv1 yum.repos.d]# gluster v stop clone1
Stopping volume will make its data inaccessible. Do you want to continue? (y/n) y
gluster v delete clone1volume stop: clone1: success
[root@rhs-arch-srv1 yum.repos.d]# gluster v delete clone1
Deleting volume will erase all information about the volume. Do you want to continue? (y/n) y
volume delete: clone1: success
[root@rhs-arch-srv1 yum.repos.d]# gluster v list
gluster_shared_storage
newvolume
vol0
vol1
[root@rhs-arch-srv1 yum.repos.d]# gluster snapshot list vol1
snap0_GMT-2017.05.02-06.35.44
snap0
snap1
snap1-2
[root@rhs-arch-srv1 yum.repos.d]# gluster snapshot clone clone1 snap0
snapshot clone: success: Clone clone1 created successfully
[root@rhs-arch-srv1 yum.repos.d]# gluster v start clone1
volume start: clone1: success
[root@rhs-arch-srv1 yum.repos.d]# 

Can create clones with same name as previous deleted clone.
Bug verified on build glusterfs-3.8.4-24.el7rhgs.x86_64

Comment 19 errata-xmlrpc 2017-09-21 04:25:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774

Comment 20 errata-xmlrpc 2017-09-21 04:53:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2774