Bug 1310895

Summary:	Adding a duplicate Foreman provider name never redirects to the flash message
Product:	Red Hat CloudForms Management Engine	Reporter:	Drew Bomhof <dbomhof>
Component:	Providers	Assignee:	Drew Bomhof <dbomhof>
Status:	CLOSED ERRATA	QA Contact:	Jan Krocil <jkrocil>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	cpelland, jfrey, jhardy, jprause, mfeifer, obarenbo
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	foreman:ui
Fixed In Version:	5.6.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1312046 (view as bug list)		Environment:
Last Closed:	2016-06-29 15:38:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1312046

Description Drew Bomhof 2016-02-22 22:50:18 UTC

Description of problem:

When attempting to add a Foreman provider that is a duplicate of an existing provider - the UI will never redirect to show the flash messages.


Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:
1. Create a Foreman provider
2. Create a second Foreman provider that exactly matches the first
3. Stacktrace in the server log errors with: Render and/or redirect were called multiple times in this action - UI never finishes loading.


Expected results:

UI should redirect to provider page showing flash messages


Additional info:

Comment 2 CFME Bot 2016-02-29 20:45:40 UTC

https://github.com/ManageIQ/manageiq/pull/7015

Comment 3 CFME Bot 2016-02-29 21:55:54 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ce87161340b82a63b90fb20546f15005f0e9e379

commit ce87161340b82a63b90fb20546f15005f0e9e379
Author:     Drew Bomhof <dbomhof>
AuthorDate: Mon Feb 29 15:07:16 2016 -0500
Commit:     Drew Bomhof <dbomhof>
CommitDate: Mon Feb 29 15:07:16 2016 -0500

    Move replace_right_cell out of the errors conditional
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1310895

 app/controllers/provider_foreman_controller.rb       |  2 +-
 spec/controllers/provider_foreman_controller_spec.rb | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

Comment 4 CFME Bot 2016-03-01 20:51:31 UTC

New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=0232849a5941d31e1a1f8d230d53e5ec2bfd3b9c

commit 0232849a5941d31e1a1f8d230d53e5ec2bfd3b9c
Author:     Drew Bomhof <dbomhof>
AuthorDate: Mon Feb 29 15:07:16 2016 -0500
Commit:     Drew Bomhof <dbomhof>
CommitDate: Tue Mar 1 10:01:25 2016 -0500

    Move replace_right_cell out of the errors conditional
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1310895

 app/controllers/provider_foreman_controller.rb       |  2 +-
 spec/controllers/provider_foreman_controller_spec.rb | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

Comment 5 Jan Krocil 2016-04-19 13:45:54 UTC

Verified fixed in 5.6-beta2 - 5.6.0.1-beta2.20160413141124_e25ac0e.
Flash message is now correctly shown when trying to add a duplicate provider.

Comment 7 errata-xmlrpc 2016-06-29 15:38:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348