Bug 1311578
| Summary: | SMB: SMB crashes with AIO enabled on reads + vers=3.0 | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | rjoseph |
| Component: | gluster-smb | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.7.9 | CC: | annair, asrivast, bturner, bugs, byarlaga, nlevinki, rcyriac, rhs-smb, rjoseph, sankarshan, sbhaloth, storage-qa-internal |
| Target Milestone: | --- | Keywords: | ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1303995 | Environment: | |
| Last Closed: | 2016-04-19 06:58:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1302901, 1303995 | ||
| Bug Blocks: | |||
|
Comment 1
Vijay Bellur
2016-02-24 14:10:16 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions REVIEW: http://review.gluster.org/13512 (libgfapi: glfd close is not correctly handled for async fop) posted (#2) for review on release-3.7 by Rajesh Joseph (rjoseph) REVIEW: http://review.gluster.org/13512 (libgfapi: glfd close is not correctly handled for async fop) posted (#3) for review on release-3.7 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/13512 committed in release-3.7 by Niels de Vos (ndevos) ------ commit e761050fb44b28c0641dd87f5fbc9d1511bed92b Author: Rajesh Joseph <rjoseph> Date: Tue Feb 2 04:22:04 2016 +0530 libgfapi: glfd close is not correctly handled for async fop There is chance that before the async fop is complete client can send a close. libgfapi destroys glfd on close. Therefore it can lead to crash or unexpected behaviour when the pening fop reaches libgfapi layer. Currently we don't provide any api to cancel these outstanding fops neither we check if the glfd is already closed or not. Therefore as a fix provided refcount for glfd. Each fop (sync or async) will take a ref and once the fop is complete it will unref the refcount. We should not call the registered callback function if glfd is already closed. To achieve this we maintain state of glfd so that we can safely take a call if the fd is closed or not. Backport of commit 88d772c05c45c467bfccebfc51f6a0e0ea9ca287: > Change-Id: Ibe71b2225312db3f1be66b244fcf8826c70c357d > BUG: 1303995 > Signed-off-by: Rajesh Joseph <rjoseph> > Reviewed-on: http://review.gluster.org/13340 > Smoke: Gluster Build System <jenkins.com> > CentOS-regression: Gluster Build System <jenkins.com> > Reviewed-by: Shyamsundar Ranganathan <srangana> > NetBSD-regression: NetBSD Build System <jenkins.org> Change-Id: I1e01690ea72f34c12465eb084d7a1aa9de0d7b83 BUG: 1311578 Signed-off-by: Rajesh Joseph <rjoseph> Reviewed-on: http://review.gluster.org/13512 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.com> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.10, please open a new bug report. glusterfs-3.7.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-April/026164.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |