Bug 1311908

Summary:	Edit VM dialog save action calls UpdateVmDiskCommand even though no disk change happened
Product:	[oVirt] ovirt-engine	Reporter:	Martin Sivák <msivak>
Component:	BLL.Virt	Assignee:	Marek Libra <mlibra>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.0.0	CC:	alukiano, bugs, mavital, mgoldboi, michal.skrivanek, tjelinek
Target Milestone:	ovirt-3.6.5	Keywords:	Triaged
Target Release:	3.6.5	Flags:	rule-engine: ovirt-3.6.z+ mgoldboi: planning_ack+ michal.skrivanek: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.6.5-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-21 14:35:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1160094

Description Martin Sivák 2016-02-25 10:02:57 UTC

Description of problem:

Usability and UX issue. This does not break any functionality.

When the Edit VM dialog is dismissed using the OK button two backend commands are called:

UpdateVmCommand and UpdateVmDiskCommand

We only allow editing some fields for the hosted engine VM and check for it in the UpdateVmCommand. But the user always gets an error from the UpdateVmDisk command because it specifically disallows changes to hosted engine VM's disks.

This would be fine if the user actually attempted to change something in the disk area. But the error is displayed even when no disk change is requested.

Version-Release number of selected component (if applicable):

master branch, but probably 3.6 too

How reproducible:

Always

Steps to Reproduce:
1. Use hosted engine VM or change the origin type of some arbitrary VM to 6 (MANAGED_HOSTED_ENGINE)
2. Edit VM (pre 3.6.3, or ask for my patches)
3. Observe the error

Actual results:

Disk update command is always called and always shows the error message.

Expected results:

Disk update should only be executed when a change is detected.

Comment 1 Martin Sivák 2016-03-02 10:31:59 UTC

*** Bug 1304323 has been marked as a duplicate of this bug. ***

Comment 2 Artyom 2016-04-13 12:55:37 UTC

Verified on rhevm-3.6.5.3-0.1.el6.noarch