Bug 131227

Created attachment 103231 [details]
a screenshot in the ja locale

Bug filed upstream.

http://bugzilla.ximian.com/show_bug.cgi?id=64485

Bug still exist in the latest evolution-data-server.

evolution-2.0.2-5
evolution-data-server-devel-1.0.2-4
evolution-devel-2.0.2-5
evolution-data-server-1.0.2-4
evolution-webcal-1.0.10-1
evolution-connector-2.0.2-1
evolution-debuginfo-2.0.2-5

Some problems here: input method can't be activated, since the widget
responds to characters being typed by turning the selected time region
into a text entry field that becomes a new appointment.  There isn't
an initial "become text entry" stage.

Seems to be much harder (but still possible) to reproduce with
evolution 2.1.3.1 (as opposed to 2.0.2, where it's 100% reproducable).

Seeing problems in 2.1.3.1 where pressing return to commit the
japanese preedit (for example) leaves it still in a preedit state.

See also bug 140813

Moving to U2.

looks like when the editing was done, I mean after clicking another cell, the
widget doesn't call gtk_im_context_reset(). so the calendar widget is lacking of
some code for supporting the input methods.

Please DO NOT reply to this by email. All additional comments should be made
inthe comments box of this bug report.

http://bugzilla.gnome.org/show_bug.cgi?id=264485 
Evolution | Calendar | Ver: 1.5

------- Additional Comments From Yong Sun  2005-04-25 07:01 -------
It seems that e-day-view.c::e_day_view_do_key_press () does not pass this
keypress to gtk immodule.

Please DO NOT reply to this by email. All additional comments should be made
inthe comments box of this bug report.

http://bugzilla.gnome.org/show_bug.cgi?id=264485
 Evolution | Calendar | Ver: 1.5

------- Additional Comments From Yong Sun  2005-04-26 10:45 -------
Suresh, could you please look at this patch? 

And, if iiim is used as the im module of gtk, gtk_im_context_filter_keypress
()always return true (even before the IM is activated by ctrl+space), while
ximworks fine in this case.

------- You are receiving this mail because: -------
You reported the bug.

Please DO NOT reply to this by email. All additional comments should be made
inthe comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=264485
Evolution | Calendar | Ver: 1.5

Yong Sun changed:
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Suresh.Chandrasekharan
                   |                            |OM

------- Additional Comments From Yong Sun  2005-04-26 10:42 -------
--- e-day-view.c.orig   2004-11-30 11:17:51.000000000 +0800
+++ e-day-view.c.new    2005-04-26 18:10:10.550333288 +0800

        cal_component_get_uid (comp, &uid);
        if (e_day_view_find_event_from_uid (day_view, uid, &day, &event_num)) {
+               gboolean im_handled = FALSE;
+               EDayViewEvent *edv_event = NULL;
+               GtkIMContext *im_context = NULL;
+
+               if (day == E_DAY_VIEW_LONG_EVENT) {
+                       edv_event = &g_array_index
(day_view->long_events,EDayViewEvent,
+                                                   event_num);
+                } else {
+                       edv_event = &g_array_index
(day_view->events[day],EDayViewEvent,
+                                                   event_num);
+                }
+
+               if (edv_event->canvas_item)
+                       g_object_get (G_OBJECT (edv_event->canvas_item),
+                                     "im_context", &im_context,
+                                     NULL);
+
+               im_handled = im_context?
gtk_im_context_filter_keypress(im_context, (GdkEventKey*)event): FALSE;
+
                e_day_view_start_editing_event (day_view, day, event_num,
-                                               initial_text);
+                                               im_handled? NULL:
initial_text);
        } else {
                g_warning ("Couldn't find event to start editing.\n");
}

------- You are receiving this mail because: -------
You reported the bug.

Hi Yong,
From a quick look I think similar issues may be there in week/month views,
didyou test them ?

I have found some weird behaviours with month view when trying to inputjapanese.
Check it, I think we need to have a fix for all those calendar inputissues together.

Pl. let me know if you need any help, I will be away for a while on a
vacation,but ofcouse if this one do affect all views we can make it a stopper
and fix itin one of the later builds in  Cinnabar itself.

------- You are receiving this mail because: -------
You reported the bug.

Please DO NOT reply to this by email. All additional comments should be made
inthe comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=264485
 Evolution | Calendar | Ver: 1.5

------- Additional Comments From suresh  2005-04-26 23:15 -------
Sorry for those comments about Cinnabar, I just forgot this is gnome bugzilla. :(

------- You are receiving this mail because: -------
You reported the bug.

------- Additional Comment #9 From Yong Sun  2005-04-27 03:28 UTC -------

Hi, Suresh,

I just found this fix also affects "Work Week" view. While weekly and monthly
view don't have this problem. :)

From my reading of the patch suggested upstream, am I right in thinking the
patch covers only some of the calendar views?

Sorry for not updating this bug, I missed this.  You won't need any patches for
this as long as you take two patches in Bug#154360.

154360 is fixed; so should this one be closed as well?

yes, it should be.

As I mentioned at https://bugzilla.redhat.com/bugzilla/process_bug.cgi#c2, this
problem isn't yet fixed.

tagoh: it's not clear from comment #23 which bug you were referring to.

What's the remaining problem here?  comment #22 suggests that it is fixed,
comment #23 that it isn't.

Tested in U2, the bug seems to be fixed. 
Tagoh-san, is that anything you wish to clarify in regards to Comment #25?


evolution-data-server-1.0.2-9
evolution-devel-2.0.2-22
evolution-data-server-1.0.2-9
evolution-data-server-devel-1.0.2-9
evolution-webcal-1.0.10-3
evolution-connector-2.0.2-8
evolution-2.0.2-22

libgal2-2.2.3-10

Oops, I'm sorry. correct URL is
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166231#c2

Comment #26:
Lawrence, I'm not sure how you did test this on RHEL4, unfortunately I can still
reproduce this problem.

The steps how to reproduce this are:
1. run evolution with LANG=ja_JP.UTF-8
2. select the day view on the calendar
3. press 'a' say on any time slot
4. press ctrl+space
5. type a k a
6. click on another time slot (at this time, it leaves the input mode.)
7. press 'a' say (it will enters into the input mode again)
8. press a again

after this step, a<u>ããã</u> will appears on 2nd time slot you clicked at
step 6. the underlining means it's still in the preediting and that reason is
what I said on Comment #27's URL.

HTH,

YES! You are right. I was fooled by my own Bug Description. :p
I switched off the LE and clicked on the second time slot, thanks for pointing
it out.

Does Yong Sun's patch in upstream bugzilla fix this problem, at least in one of
the views?  From the discussion in the upstream BZ it looks like we'd have to go
through and fix the various views individually.

*** Bug 166231 has been marked as a duplicate of this bug. ***

Created attachment 129593 [details]
Patch to tackle preedit buffer duplication problem

This patch seemingly solves the bug.
Can the QA team kindly confirm this :)

Thanks,
Mayank

Thanks for the patch. We can include this bug in this month's bug sweep if you
have test rpm available.

Include a link here will be fine. 

This bug is already a private bug, so private message is not necessary as
everyone able to view this bug will be able to see the comment anyway. :)

Created attachment 129791 [details]
A better looking patch

Moving from MODIFIED to ASSIGNED.
Adding llch to CC.

The upstream code has bugfix for this without the patch in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=131227#c41

Matthew, can you please comment on how RHEL bug which need fixes from new code
is to be patched (because of version difference in lots of dependency libraries).

Is the patch in upstream needs to be backported or will we fork from an FC
release for RHEL5?

Thanks,
Mayank

Mayank, Evolution in RHEL5 will probably be FC6 + some updates.

Hi Matt,

The Patch in http://bugzilla.gnome.org/attachment.cgi?id=65213&action=view seems
to be missing from the latest builds. Can you please apply it to the latest code
base?

As you mentioned, RHEL5 would be FC6+updates, then this patch can go directly
into RHEL5 without backporting. 

Pls let me know if you need any help regarding this.

PS: this is same bug as bug #166231 and bug #157391 & hopefully the same patch
should do.

Thanks,
Mayank

Done - evolution-2.7.3-8

Only two of the three hunks in the patch applied.  The third (plugs a memory
leak) is already fixed upstream.

Changing component from evolution-data-server to evolution.

Created attachment 132798 [details]
Another patch 

Hi Matthew,
This is another patch from me, kindly apply it & try to reproduce the problem.
If it seems working, kindly put up a reply upstream.

This time we'll include the patch only after its accepted upstrem, so as we
dont have to revert it.

Thanks,
Mayank

Not fixed in latest Version:
--------
evolution-2.0.2-27.rhel4.3
------

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

devel_ack -- Patch is available, looks pretty simple.

Matthew, is it okay to accept a patch before its not in upstream?

Mayank, I will devel_nack this if the patch doesn't work and we can't produce
one that does by RHEL5 code freeze.

Matthew, the patch in http://bugzilla.gnome.org/show_bug.cgi?id=264485#c72 does
works, even Ikezoe san has confirmed this. However, we are just waiting for
Andre's approval (who is testing the patch). But it seems that he is running
into troubles with activating scim with evo. 

If you have 10 free minutes & have latest evo, can you please apply the patch &
let Andre know on gnome bz, so as we can push this patch in Beta2.

Thanks in advance,
Mayank

Can you address Chen's comment [1] in the upstream bug report?  It sounds like
he noticed some side-effects that might be solved by a gtk_im_context_reset()
(like we did with that recent RHEL-5 bug that I can't remember the number for).

[1] http://bugzilla.gnome.org/show_bug.cgi?id=264485#c86

Changing component to libgal2.

Patch applied to libgal2-2.2.3-11.el4.

Had to apply the patch by hand, and I made a typo that causes Evolution to crash.

Here's a better version: libgal2-2.2.3-12.el4

Evolution 2.0.2 is only being updated for security issues.  Closing as WONTFIX.