Bug 131314
| Summary: | s-c-date changes break firstboot date module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adrian Likins <alikins> | ||||
| Component: | system-config-date | Assignee: | Nils Philippsen <nphilipp> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 3 | CC: | byte | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2004-11-23 16:49:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 131308 | ||||||
| Attachments: |
|
||||||
(Pasting from PM): IIUC firstboot should be using the mainWindow.childWindow class (and its launch() method) for getting the s-c-date window. The xml parameter is a glade xml reference, mainWindow should handle that. Please tell me what specific hooks you need into s-c-date from firstboot if a hook to get the main window contents isn't enough... hmm, i'l take a look at mainWindow.childWindow if thats the prefered mechanism (it wasnt what it was using before, no idea why...). I got it working with a whee bit of kluging using date_gui directly (but it displays weird, so probabaly not ideal). That will display date and timezone on the same page though. Offhand, I have no idea is thats whats desired or not. Okay, got it working with mainWindow.childWindow, but now the dialog is too big and doesnt fit within the screen for firstboot (the contents in ntpFrame are partially obscured). Since I belive the max size of firstboot is fixed, need to figure out someway to fix this (and putting the whole thing inside a scrollable window seems like bad ui...). i'll attach a screenshot Created attachment 103371 [details]
screenshot of the date-time dialog in firstboot
I see. Maybe the whole NTP server chooser stuff should go into its own tab, what do you think? Or perhaps even a "Configure Network Time Protocol" button with its own window -- I can't seem to think of a way to fit this all into firstboot _and_ have a UI that doesn't suck... Luckily I have done the transition to glade already. It still has some quirks here and there, but rearranging the UI should go rather quickly now. I just put the whole NTP stuff into its own tab. Please check whether this fixes your firstboot issues once 1.7.5-1 is out. Please see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=132442 I've uploaded a screenshot on that bug's page. Well, 1.7.7-1 should do the trick now. |
Description of problem: Theres a couple issues with system-config-date-1.7.4 that are causing problems with the "date" module in firstboot. 1. the params to date_gui.datePage changed and now require a xml tag. If I create the gtk.glade.XML object myself and pass it in, I can get past this, but that seems odd. 2. the custom_widgets stuff gets setup by MainWindow and isnt called for the firstboot case. I can call this in the date.py for firstboot, but it seems a bit odd 3. getVBox is busted return self.mainVBox when no self.mainVbox exist. This is the call firstboot uses to grab the vbox to reparent for the firstboot dialog. If I work around that and try to get to the main vbox ("vbox2") in the firstboot "date.py" it stops traceing back, but no widgets are shown.