Bug 131314 - s-c-date changes break firstboot date module
Summary: s-c-date changes break firstboot date module
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-date
Version: 3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 131308
TreeView+ depends on / blocked
 
Reported: 2004-08-30 21:03 UTC by Adrian Likins
Modified: 2007-11-30 22:10 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2004-11-23 16:49:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
screenshot of the date-time dialog in firstboot (61.72 KB, image/png)
2004-09-01 20:38 UTC, Adrian Likins
no flags Details

Description Adrian Likins 2004-08-30 21:03:22 UTC
Description of problem:

Theres a couple issues with system-config-date-1.7.4
that are causing problems with the "date" module
in firstboot.

1. the params to date_gui.datePage changed and now
    require a xml tag. 

    If I create the gtk.glade.XML object myself and
    pass it in, I can get past this, but that seems
    odd. 

2. the custom_widgets stuff gets setup by MainWindow
   and isnt called for the firstboot case.

   I can call this in the date.py for firstboot, but
   it seems a bit odd

3. getVBox is busted
     return self.mainVBox  when no self.mainVbox exist.

    This is the call firstboot uses to grab the vbox to
    reparent for the firstboot dialog. 

    If I work around that and try to get to the main
    vbox ("vbox2") in the firstboot "date.py" it stops
    traceing back, but no widgets are shown.

Comment 1 Nils Philippsen 2004-09-01 20:19:56 UTC
(Pasting from PM):

IIUC firstboot should be using the mainWindow.childWindow class (and its
launch() method) for getting the s-c-date window. The xml parameter is a
glade xml reference, mainWindow should handle that. Please tell me
what specific hooks you need into s-c-date from firstboot if a hook to
get the main window contents isn't enough...


Comment 2 Adrian Likins 2004-09-01 20:25:00 UTC
hmm, i'l take a look at mainWindow.childWindow if thats the
prefered mechanism (it wasnt what it was using before,
no idea why...).

I got it working with a whee bit of kluging using date_gui
directly (but it displays weird, so probabaly not ideal). 

That will display date and timezone on the same 
page though. Offhand, I have no idea is thats whats desired
or not. 



Comment 3 Adrian Likins 2004-09-01 20:37:45 UTC
Okay, got it working with mainWindow.childWindow,
but now the dialog is too big and doesnt fit
within the screen for firstboot (the contents
in ntpFrame are partially obscured). Since
I belive the max size of firstboot is fixed,
need to figure out someway to fix this
(and putting the whole thing inside a
scrollable window seems like bad ui...).

i'll attach a screenshot

Comment 4 Adrian Likins 2004-09-01 20:38:41 UTC
Created attachment 103371 [details]
screenshot of the date-time dialog in firstboot

Comment 5 Nils Philippsen 2004-09-02 21:33:19 UTC
I see. Maybe the whole NTP server chooser stuff should go into its own
tab, what do you think? Or perhaps even a "Configure Network Time
Protocol" button with its own window -- I can't seem to think of a way
to fit this all into firstboot _and_ have a UI that doesn't suck...

Luckily I have done the transition to glade already. It still has some
quirks here and there, but rearranging the UI should go rather quickly
now.

Comment 6 Nils Philippsen 2004-09-02 22:01:30 UTC
I just put the whole NTP stuff into its own tab. Please check whether
this fixes your firstboot issues once 1.7.5-1 is out.

Comment 7 Max Spevack 2004-09-13 17:58:00 UTC
Please see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=132442

I've uploaded a screenshot on that bug's page.

Comment 8 Nils Philippsen 2004-09-14 16:28:54 UTC
Well, 1.7.7-1 should do the trick now.


Note You need to log in before you can comment on or make changes to this bug.