Bug 1315170

Summary: Wrong interpretation of disk size in gverify.sh script
Product: [Community] GlusterFS Reporter: Saravanakumar <sarumuga>
Component: geo-replicationAssignee: Saravanakumar <sarumuga>
Status: CLOSED NOTABUG QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.7.9CC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1305839 Environment:
Last Closed: 2016-03-07 06:56:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1305839    
Bug Blocks:    

Description Saravanakumar 2016-03-07 06:48:17 UTC
+++ This bug was initially created as a clone of Bug #1305839 +++

Description of problem:

Run gverify script as below:
#/usr/local/libexec/glusterfs/gverify.sh  tv1 root gfvm4 tv2 22 /tmp/test.log 

Testing_Passwordless_SSH
/usr/local/libexec/glusterfs/gverify.sh: line 206: [: 1-blocks: integer expression expected

Version-Release number of selected component (if applicable):


How reproducible:
This bug is not easily reproducible, as it is not returning any error.

If the script is executed standalone, then only it can be reproduced.

Steps to Reproduce:
1. Setup geo-replication
2. Run gverify script


Actual results:
Throws error "integer expression expected"

Expected results:
Should not throw any error. 
returns 0 for success, can be verified as echo $? after executing the script.


Additional info:

--- Additional comment from Vijay Bellur on 2016-02-09 06:33:10 EST ---

REVIEW: http://review.gluster.org/13407 (geo-rep: Fix invalid disk size in gverify.sh) posted (#2) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Vijay Bellur on 2016-03-01 02:57:24 EST ---

COMMIT: http://review.gluster.org/13407 committed in master by Jeff Darcy (jdarcy) 
------
commit a35bfdaa6279a981a84e8831d65702496f1e478e
Author: Saravanakumar Arumugam <sarumuga>
Date:   Tue Feb 9 16:44:03 2016 +0530

    geo-rep: Fix invalid disk size in gverify.sh
    
    Problem:
            Due to the wrong interpretation of disk size, gverify.sh script
    exits in between with error "integer expression expected".
    This error can be observed, only if gverify.sh is run standalone.
    
    Solution:
            Fix the interpretation of disk size.
    
    Also, verify that master and slave's gluster version are same.
    
    Change-Id: Id095dfffd07a93a535a380f617ad215230979870
    BUG: 1305839
    Signed-off-by: Saravanakumar Arumugam <sarumuga>
    Reviewed-on: http://review.gluster.org/13407
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Aravinda VK <avishwan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Saravanakumar 2016-03-07 06:56:22 UTC
not applicable in 3.7, so closing the bug.