Bug 1315186
| Summary: | setting lower op-version should throw failure message | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Gaurav Kumar Garg <ggarg> | |
| Component: | glusterd | Assignee: | Satish Mohan <smohan> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, bugs, mzywusko, nlevinki, rhinduja, sasundar, smohan, vbellur | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1101702 | |||
| : | 1315562 1330545 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 13:59:22 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1101702 | |||
| Bug Blocks: | 1315562, 1330545 | |||
|
Comment 1
Vijay Bellur
2016-03-07 08:16:26 UTC
REVIEW: http://review.gluster.org/13622 (glusterd: avoid setting op-version lower than current cluster op-version) posted (#2) for review on master by Gaurav Kumar Garg (ggarg) REVIEW: http://review.gluster.org/13622 (glusterd: avoid setting op-version lower than current cluster op-version) posted (#3) for review on master by Gaurav Kumar Garg (ggarg) COMMIT: http://review.gluster.org/13622 committed in master by Atin Mukherjee (amukherj) ------ commit 2d87a981657ee23d00c20813deddeb320e0afa8f Author: Gaurav Kumar Garg <garg.gaurav52> Date: Mon Mar 7 13:37:31 2016 +0530 glusterd: avoid setting op-version lower than current cluster op-version Currently glusterd allow setting a cluster op-version which is lower than current cluster op-version. Though command is successful but it does not set that lower op-version. With this fix it will return error message "Required op-version (requested op-version) should not be lower than current cluster op-version (current cluster op-version)" Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82 BUG: 1315186 Signed-off-by: Gaurav Kumar Garg <ggarg> Reviewed-on: http://review.gluster.org/13622 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> The functionality in master is broken now due to commit 2eb8758, assigning it back. REVIEW: http://review.gluster.org/14069 (glusterd: fix validation of lower op-version check in volume set) posted (#1) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/14069 committed in master by Kaushal M (kaushal) ------ commit f93761c547c39fad20f9aa96d4baf2641500b9a0 Author: Atin Mukherjee <amukherj> Date: Tue Apr 26 12:46:18 2016 +0530 glusterd: fix validation of lower op-version check in volume set Commit 2d87a98 introduced a validation to fail lowering down the cluster.op-version. Commit 2eb8758 actually changed the variable value from cluster's op-version to volume's op-version which resulted the logic go for a toss. Change-Id: I70df32b75c3a3fe47dc840c4a655059e5b124bca BUG: 1315186 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/14069 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kaushal M <kaushal> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |