Bug 1322411

Summary:	Dependencies list issues
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Tomas David <tdavid>
Component:	Business Central	Assignee:	Toni Rikkola <trikkola>
Status:	CLOSED EOL	QA Contact:	Tomas David <tdavid>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	6.3.0	CC:	etirelli, kverlaen, lpetrovi
Target Milestone:	ER3
Target Release:	6.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-27 19:12:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1326176, 1326178, 1326181, 1326184
Bug Blocks:

Description Tomas David 2016-03-30 13:00:11 UTC

Description of problem:
A) If you create an empty project and you add the project as dependency to another one, it is not possible to switch package white list option to 'Add all'.

B) If the dependency is added by specifying GAV (by 'Add' button, not by 'Add from repository' button) and the project is reopened, the dependency is gone.

C) Switching to 'Add all' option of package white list is probably possible only if a project which is added as dependency has some data object inside. When two such projects are added as dependencies and if you change package whitelist option, both options of dependencies are changed.

D) The options of package white list button behave like switch button.

Version-Release number of selected component (if applicable):
BRMS 6.3.0.ER2

How reproducible:
-

Steps to Reproduce:
A
1. Create a project. Build and deploy.
2. Create a second project. Add the first project dependency.
3. Try to switch package white list option to 'Add all'.

B. 
1. Create a project. Build and deploy.
2. Create a second project. Add the first project dependency by 'Add' button and specifying GAV.
3. Save the second project.
4. Reopen the second project.

C
1. Create two projects with some data object and use them in a third project as a dependency. 
2. Switch option of the first dependency to 'Add all'.

D
1. Create a project with some data object and use it as a dependency. 
2. Click on the package white list button and select 'Add all' option.
3. Click on the package white list button and select 'Add all' option again.

Actual results:
A Option 'Package not included' is set.
B Dependency disappears.
C Both options of dependencies are changed
D Option is switched.


Expected results:
A Option 'All packages included' is set.
B Dependency is present.
C Only the first dependency option is changed.
D Option stays 'All packages included.'


Additional info:
I create only one bugzilla for these issues because they might be related.

Comment 2 Toni Rikkola 2016-03-31 08:10:29 UTC

A.) The add all takes all the packages from the jar at the moment and adds them into the white list file. The fix for this might need some redesigning. Perhaps the right place for the "add all" button is not here. A better way might be to have the white list as a tab in the project editor. Then in the tab you can see the full white list and a list of dependencies with status about if the content is white listed or not.

B.) This should be fixed for the next release.

C.) If you have the same object with the same package and class name the project might not compile. But to white list you only need to "add all" once using either of the dependencies. Since we only add the package to the white list file.


I think B is the only actual code bug here and it has been fixed. 
A, C and D are bugs on design. To fix them adding the white list to Project Editor would be a good fix. This might help the user to understand and see what white listing does. It does not check the dependency as white listed, it looks at the content of the dependency jar and adds any packages from there to white list. If the dependency is a snapshot, the next time the user opens the Dependency tab, if the snapshot dependency has gained more packages or all the package names were renamed the status of the white list column changes.

Comment 3 Tomas David 2016-04-04 13:58:13 UTC

Thanks for the explanation Toni.

D) If the button works only as a switch button, I would recommend to use the button without the options "Add all" and "Add none". It is simpler to switch it on one click than two.

I agree with you with the separate tab for the white list where the included packages can be modified in a next version of business central.

In current version, I think it could be good if some explanation notification is displayed when it is not possible to switch to "All packages included" or when the change involves some other dependency. What do you think?

Comment 5 Tomas David 2016-04-12 06:04:20 UTC

Hi Toni, Edson,

I created separated issues. For those which can be fixed in 6.3.0, I created bugzilla tickets. See "Depends on" list.

Also I created jira for future feature:
https://issues.jboss.org/browse/GUVNOR-2485

I will let this bz open as parent for other bzs. If you think it is not necessary, feel free to close it.

Comment 6 Lukáš Petrovický 2016-04-20 06:22:53 UTC

VERIFIED with 6.3.0.ER3, follow-up issues of lower priority filed as new BZs.