Bug 1324439
| Summary: | SAMBA+TIER : Wrong message display.On detach tier success the message reflects Tier command failed. | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | hari gowtham <hgowtham> | |
| Component: | tiering | Assignee: | hari gowtham <hgowtham> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | bugs <bugs> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, bugs, josferna, kaushal, kramdoss, nchilaka, rhinduja, rhs-smb, sashinde, vdas | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1322695 | |||
| : | 1328410 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 14:03:04 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1322695 | |||
| Bug Blocks: | 1328410, 1337908 | |||
|
Comment 1
Vijay Bellur
2016-04-06 10:54:53 UTC
REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#2) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#3) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#4) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#5) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#6) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#7) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/13918 (Tier: tier command fails message when any node is down) posted (#8) for review on master by hari gowtham (hari.gowtham005) COMMIT: http://review.gluster.org/13918 committed in master by Kaushal M (kaushal) ------ commit 690715bb3e341f673a71d1dc8b80bb35aa29c75d Author: hari <hgowtham> Date: Wed Apr 6 16:16:47 2016 +0530 Tier: tier command fails message when any node is down PROBLEM: the dict doesn't get set on the node if its down. so while printing the output on cli we get a ENOENT which ends in a tier command failed. FIX: this patch skips the node that wasn't available and carrys on with the next node for both tier status and tier detach status. Change-Id: I718a034b18b109748ec67f3ace56540c50650d23 BUG: 1324439 Signed-off-by: hari <hgowtham> Reviewed-on: http://review.gluster.org/13918 Smoke: Gluster Build System <jenkins.com> Tested-by: hari gowtham <hari.gowtham005> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Kaushal M <kaushal> REVIEW: http://review.gluster.org/14347 (tier/cli : printing node unreachable instead of skipping the node) posted (#1) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#2) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#3) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#4) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#5) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#6) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#7) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/14347 (tier/cli : printing a warning instead of skipping the node) posted (#8) for review on master by hari gowtham (hari.gowtham005) COMMIT: http://review.gluster.org/14347 committed in master by Atin Mukherjee (amukherj) ------ commit d5e67cd2b2d60166f16337e4441fa50a9e488094 Author: hari gowtham <hgowtham> Date: Mon May 16 10:55:17 2016 +0530 tier/cli : printing a warning instead of skipping the node Problem: skipping the status of the nodes down creates confusion to the user as one might see the status as completed for all nodes and while performing detach commit, the operation will fail as the node is down Fix: Display a warning message Note: When the last node is down (as per the peer list) then warning message can't be displayed as the total number of peers participating in the transaction is considered to be the total count. Change-Id: Ib7afbd1b26df3378e4d537db06f41f5c105ad86e BUG: 1324439 Signed-off-by: hari gowtham <hgowtham> Reviewed-on: http://review.gluster.org/14347 Tested-by: hari gowtham <hari.gowtham005> Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> NetBSD-regression: NetBSD Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |