Bug 1328439

Summary: cfme cloud-init broken with rhev 3.5.5
Product: Red Hat CloudForms Management Engine Reporter: Prasad Mukhedkar <pmukhedk>
Component: ProvisioningAssignee: Brandon Dunne <bdunne>
Status: CLOSED EOL QA Contact: Dave Johnson <dajohnso>
Severity: urgent Docs Contact:
Priority: high    
Version: 5.4.0CC: bdunne, cpelland, ekin.meroglu, gmccullo, jhardy, jocarter, jprause, kzvyahin, mfeifer, mkanoor, ngupta, obarenbo, pmukhedk, sacpatil, tfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.4.6   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1282618 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1282618    
Bug Blocks: 1290175    
Attachments:
Description Flags
5.4.z fix tarball
none
cloudforms 4.0 logs (cloud-init) not working
none
5.4.z fix with enhanced logging none

Comment 4 Greg McCullough 2016-04-22 18:26:38 UTC
Changed target_release to 5.4.6 and updated cfme flag to match.

Comment 5 CFME Bot 2016-04-25 19:23:06 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=91ee0608c68540cc96458e8353c645d8d9361d83

commit 91ee0608c68540cc96458e8353c645d8d9361d83
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Apr 21 15:13:08 2016 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Apr 22 07:33:45 2016 -0400

    Backport: Send use_cloud_init to start when provisioning RHEV 3.5.5+ with cloud-init
    
    Mostly clean cherry-pick, just different file paths and change _log
    See 407dbdc450f6f0c8dcae90c120fd1cc7bb106fb2
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1328439

 vmdb/app/models/miq_provision_redhat/configuration.rb |  4 ++++
 vmdb/app/models/miq_provision_redhat/state_machine.rb | 11 +++++++++++
 2 files changed, 15 insertions(+)

Comment 6 CFME Bot 2016-04-25 19:23:12 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=e7a772d7cf702f920a85d85839cbd855182670d3

commit e7a772d7cf702f920a85d85839cbd855182670d3
Merge: 63ebe69 bcb7516
Author:     Jason Frey <jfrey>
AuthorDate: Mon Apr 25 15:18:12 2016 -0400
Commit:     Jason Frey <jfrey>
CommitDate: Mon Apr 25 15:18:12 2016 -0400

    Merge branch '5.4.z.backport_rhev_cloudinit_fix' into '5.4.z'
    
    5.4.z.backport rhev cloudinit fix
    
    Cherry-pick was mostly clean, had to add the patches to the ovirt gem. Minor changes for class names and _log.
    Original PR: https://github.com/ManageIQ/manageiq/pull/5603
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1328439
    
    See merge request !905

 .../models/miq_provision_redhat/configuration.rb   |  4 +++
 .../models/miq_provision_redhat/state_machine.rb   | 11 +++++++
 vmdb/lib/extensions/ovirt_api.rb                   | 27 +++++++++++++++
 vmdb/lib/extensions/ovirt_service.rb               | 18 ++++++++++
 vmdb/lib/extensions/ovirt_vm.rb                    | 16 +++++++++
 .../miq_provision_redhat/configuration_spec.rb     | 27 ++++++++++++++-
 .../miq_provision_redhat/state_machine_spec.rb     | 38 ++++++++++++++++++++++
 7 files changed, 140 insertions(+), 1 deletion(-)

Comment 7 CFME Bot 2016-04-25 19:23:18 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7e82e6b5ad8eff32579332c111df7db7a8b0b9d5

commit 7e82e6b5ad8eff32579332c111df7db7a8b0b9d5
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Apr 21 15:03:30 2016 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Thu Apr 21 15:03:30 2016 -0400

    Backport: Add specs for RHEVM use_cloud_init changes
    
    Mostly clean cherry-pick, just different file paths and constants
    See 1bc93dc7c49890654a727fb859992f3d92360da8
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1328439

 .../miq_provision_redhat/configuration_spec.rb     | 27 ++++++++++++++-
 .../miq_provision_redhat/state_machine_spec.rb     | 38 ++++++++++++++++++++++
 2 files changed, 64 insertions(+), 1 deletion(-)

Comment 8 CFME Bot 2016-04-25 19:23:25 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=bcb751619466b83bf382589c4932d3c20c443d87

commit bcb751619466b83bf382589c4932d3c20c443d87
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Apr 21 18:12:36 2016 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Apr 22 07:34:07 2016 -0400

    Backport changes to the ovirt gem in v0.7.1 for this workaround
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1328439

 vmdb/lib/extensions/ovirt_api.rb     | 27 +++++++++++++++++++++++++++
 vmdb/lib/extensions/ovirt_service.rb | 18 ++++++++++++++++++
 vmdb/lib/extensions/ovirt_vm.rb      | 16 ++++++++++++++++
 3 files changed, 61 insertions(+)
 create mode 100644 vmdb/lib/extensions/ovirt_api.rb
 create mode 100644 vmdb/lib/extensions/ovirt_service.rb
 create mode 100644 vmdb/lib/extensions/ovirt_vm.rb

Comment 10 Brandon Dunne 2016-04-26 14:29:24 UTC
Created attachment 1150974 [details]
5.4.z fix tarball

Untar from /var/www/miq.  This fix is based on version 5.4.5.2

Comment 18 Brandon Dunne 2016-06-02 17:57:58 UTC
Prasad,

I tested against your RHEV environment as well, and the version is being parsed as expected.  I don't see any reason that this would not work for the customer as long as the patch was applied to the latest 5.4.z release, which appears to be 5.4.5.2.  Do they have any other patches applied that may have conflicted with this one?

Comment 20 Prasad Mukhedkar 2016-06-03 10:39:01 UTC
Created attachment 1164432 [details]
cloudforms 4.0 logs (cloud-init) not working

Comment 21 Sachin 2016-06-09 04:54:42 UTC
Brandon,

I don't see configuration_spec.rb & state_machine_spec.rb file included in the tarball. Is this expected?


--
Sachin

Comment 22 Brandon Dunne 2016-06-13 13:35:07 UTC
Sachin,

We don't usually include tests in the tarball since they won't be run in that environment.

Comment 24 Brandon Dunne 2016-06-15 16:29:56 UTC
Created attachment 1168455 [details]
5.4.z fix with enhanced logging

This fix adds the following logging in the state machine.  These messages will appear in the evm.log.

XXXXX SOURCE.EMS.API_VERSION:
XXXXX PHASE_CONTEXT[:boot_with_cloud_init] 1:
XXXXX PHASE_CONTEXT[:boot_with_cloud_init] 2:

Comment 28 Brandon Dunne 2016-06-29 13:38:44 UTC
Resolved by https://bugzilla.redhat.com/show_bug.cgi?id=1348614