Bug 1328828

Summary: Entered data in provision form of request tab is lost.
Product: Red Hat CloudForms Management Engine Reporter: Niyaz Akhtar Ansari <nansari>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: medium Docs Contact:
Priority: high    
Version: 5.6.0CC: cpelland, dajohnso, fdewaley, hgeaydem, hkataria, jhardy, jprause, lavenel, mhradil, mpovolny, nansari, obarenbo, simaishi
Target Milestone: Beta 2Keywords: ZStream
Target Release: 5.6.0Flags: nansari: automate_bug+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: provision
Fixed In Version: 5.6.0.6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1350968 (view as bug list) Environment:
Last Closed: 2016-06-29 15:51:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1347704, 1347705, 1350968    
Attachments:
Description Flags
screenshot none

Description Niyaz Akhtar Ansari 2016-04-20 11:26:27 UTC
Created attachment 1149041 [details]
screenshot

Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.1-beta2.20160413141124_e25ac0e

How reproducible:
100%

Steps to Reproduce:
1.Navigate to infrastructure->Virtual Machines->Provision VMs
2.Select Template and click on Continue->fill all required details in provision form 
3.after filling the form again navigate to request tab.

Actual results:
The data entered in request tab textboxes is lost.

Expected results:
The values should not be lost. 

Additional info:

Comment 2 Greg McCullough 2016-04-20 14:27:29 UTC
This was also reported as a git issue here: https://github.com/ManageIQ/manageiq/issues/8054

I tested with the latest upstream and this is working.  Can you please retest with the next build.

Comment 3 Niyaz Akhtar Ansari 2016-04-26 08:46:05 UTC
This issue is still reproducible in latest build 

Build Version 5.6.0.4-beta2.3.20160421172650_719e256

Comment 5 Harpreet Kataria 2016-04-28 21:29:43 UTC
Niyaz,

Can you please provide a link to an appliance where i can see this happening. I am unable to recreate this issue locally on a latest upstream codebase.

Thanks,
~Harpreet

Comment 6 Niyaz Akhtar Ansari 2016-04-29 07:11:41 UTC
Harpreet,

This is my appliance link 10.16.5.111 .You can reproduce this Bug.

Thanks,
~Niyaz

Comment 7 Martin Povolny 2016-04-29 19:10:27 UTC
Looking at the issue using the browser debugger, I think that what is happening here is this:

* the appliance is pretty slow
* you are typing and clicking fast
* this form was not converted to angular

what is happening is that the on-field-change updates etc. take too long or do not fire yet as you fill in stuff in the form

therefor if you click next tab and then back some of the stuff you typed is lost, because it was not yet saved to the server

do not really know what to do here atm. We will rewrite this form to angular at some point.

For now
a) type slower
b) get a better virtual HW for your appliance

Comment 9 Martin Hradil 2016-05-04 07:20:36 UTC
https://github.com/ManageIQ/manageiq/pull/8421

Comment 10 Harpreet Kataria 2016-05-09 15:54:03 UTC
https://github.com/ManageIQ/manageiq/pull/8544 fixes an issue introduced in https://github.com/ManageIQ/manageiq/pull/8421

Comment 11 CFME Bot 2016-05-09 20:45:58 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b1872d436d2c70f67ed97c5d9df55bddcf2b4b79

commit b1872d436d2c70f67ed97c5d9df55bddcf2b4b79
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 9 10:17:19 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon May 9 12:29:45 2016 -0400

    Removed .off on change event from bootstrap selects
    
    Don't need to turn off on change event on selects as there are no other observers on the selects. This was causing it to not display selected value as selected in selects after user made a selection on some of the selects.
    
    Fixes #8537
    https://bugzilla.redhat.com/show_bug.cgi?id=1328828

 app/assets/javascripts/miq_application.js | 1 -
 1 file changed, 1 deletion(-)

Comment 13 Niyaz Akhtar Ansari 2016-05-12 06:38:32 UTC
Entered data in request tab textboxes are not lost.Its Working Successfully  

verified in 5.6.0.6-beta2.5.20160511140943_ff75fb2

Comment 15 CFME Bot 2016-06-21 17:37:57 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=4656e1dcec2fc5458be64a6f8bbd7b937e4ab4e2

commit 4656e1dcec2fc5458be64a6f8bbd7b937e4ab4e2
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 9 10:17:19 2016 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Tue Jun 21 15:32:59 2016 +0000

    Removed .off on change event from bootstrap selects
    
    Don't need to turn off on change event on selects as there are no other observers on the selects. This was causing it to not display selected value as selected in selects after user made a selection on some of the selects.
    
    Fixes #8537
    https://bugzilla.redhat.com/show_bug.cgi?id=1328828
    
    (cherry picked from commit b1872d436d2c70f67ed97c5d9df55bddcf2b4b79)

 app/assets/javascripts/miq_application.js | 1 -
 1 file changed, 1 deletion(-)

Comment 18 errata-xmlrpc 2016-06-29 15:51:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Comment 19 eclarizi 2016-07-08 17:47:27 UTC
*** Bug 1344062 has been marked as a duplicate of this bug. ***

Comment 20 eclarizi 2016-07-08 17:50:44 UTC
*** Bug 1347704 has been marked as a duplicate of this bug. ***