Bug 1333241

Summary:	Fix excessive logging due to NULL dict in dht
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	distribute	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1333043	Environment:
Last Closed:	2016-06-28 12:16:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1333043, 1333244, 1335364
Bug Blocks:

Description Krutika Dhananjay 2016-05-05 05:22:20 UTC

+++ This bug was initially created as a clone of Bug #1333043 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-04 10:49:28 EDT ---

REVIEW: http://review.gluster.org/14212 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-05-05 01:14:41 EDT ---

COMMIT: http://review.gluster.org/14212 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 09966fff2588e41410eabe75003346edd20404ab
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    Change-Id: I367628fee2f6783ba9ed6f918deabd034df820c9
    BUG: 1333043
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14212
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Vijay Bellur 2016-05-05 05:23:37 UTC

REVIEW: http://review.gluster.org/14216 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-05-06 06:48:10 UTC

COMMIT: http://review.gluster.org/14216 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit ef14971b36aa7c41bcfc13620bceecf97f508c57
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
            Backport of: http://review.gluster.org/14212
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    
    Change-Id: I443322d26f2b5238320bc14f1ddc94affe030943
    BUG: 1333241
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14216
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2016-06-28 12:16:49 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user