Bug 1333043 - Fix excessive logging due to NULL dict in dht
Summary: Fix excessive logging due to NULL dict in dht
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1333241 1333244 1335364
TreeView+ depends on / blocked
 
Reported: 2016-05-04 14:45 UTC by Krutika Dhananjay
Modified: 2016-06-28 12:05 UTC (History)
2 users (show)

Fixed In Version: 3.7.9
Clone Of:
: 1333241 1333244 1335364 (view as bug list)
Environment:
Last Closed: 2016-06-28 12:05:11 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2016-05-04 14:45:28 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-04 14:49:28 UTC
REVIEW: http://review.gluster.org/14212 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-05-05 05:14:41 UTC
COMMIT: http://review.gluster.org/14212 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 09966fff2588e41410eabe75003346edd20404ab
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    Change-Id: I367628fee2f6783ba9ed6f918deabd034df820c9
    BUG: 1333043
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14212
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 krishnaram Karthick 2016-05-31 04:57:07 UTC
The 'dict is NULL' logging from dict_get() is no more seen during or after rebalance operation. 

Marking the bug as verified in glusterfs-3.7.9-6.


Note You need to log in before you can comment on or make changes to this bug.