Bug 1333244 - Fix excessive logging due to NULL dict in dht
Summary: Fix excessive logging due to NULL dict in dht
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1333043 1335364
Blocks: 1333241
TreeView+ depends on / blocked
 
Reported: 2016-05-05 05:28 UTC by Krutika Dhananjay
Modified: 2016-06-16 14:05 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1333043
Environment:
Last Closed: 2016-06-16 14:05:31 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2016-05-05 05:28:16 UTC
+++ This bug was initially created as a clone of Bug #1333043 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-04 10:49:28 EDT ---

REVIEW: http://review.gluster.org/14212 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-05-05 01:14:41 EDT ---

COMMIT: http://review.gluster.org/14212 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 09966fff2588e41410eabe75003346edd20404ab
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    Change-Id: I367628fee2f6783ba9ed6f918deabd034df820c9
    BUG: 1333043
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14212
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Vijay Bellur 2016-05-05 05:29:18 UTC
REVIEW: http://review.gluster.org/14218 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on release-3.8 by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-05-06 14:15:06 UTC
COMMIT: http://review.gluster.org/14218 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 036dcd39bfa40473073d45c10a0daec63fbca2ab
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
            Backport of: http://review.gluster.org/14212
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    
    Change-Id: Ic2f21532f09af3ab7d36ce5f20c561fff5208fbb
    BUG: 1333244
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14218
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 14:05:31 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.