Bug 1335364

Summary: Fix excessive logging due to NULL dict in dht
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Raghavendra G <rgowdapp>
Component: distributeAssignee: Raghavendra G <rgowdapp>
Status: CLOSED ERRATA QA Contact: krishnaram Karthick <kramdoss>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: amukherj, asrivast, bugs, kdhananj, mchangir, rcyriac, rhinduja, smohan
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: RHGS 3.1.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.9-5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1333043 Environment:
Last Closed: 2016-06-23 05:22:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1333043    
Bug Blocks: 1311817, 1333241, 1333244    

Description Raghavendra G 2016-05-12 05:08:44 UTC 
+++ This bug was initially created as a clone of Bug #1333043 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-04 10:49:28 EDT ---

REVIEW: http://review.gluster.org/14212 (cluster/dht: Perform NULL check on xdata before dict_get()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-05-05 01:14:41 EDT ---

COMMIT: http://review.gluster.org/14212 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 09966fff2588e41410eabe75003346edd20404ab
Author: Krutika Dhananjay <kdhananj>
Date:   Wed May 4 20:16:36 2016 +0530

    cluster/dht: Perform NULL check on xdata before dict_get()
    
    .. to prevent unnecessary logs from gf_msg_callingfn()
    
    Change-Id: I367628fee2f6783ba9ed6f918deabd034df820c9
    BUG: 1333043
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14212
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
Comment 2 Raghavendra G 2016-05-12 05:10:10 UTC 
Should be considered for 3.1.3 as excessive logging affects debuggability.
Comment 3 Raghavendra G 2016-05-16 04:54:36 UTC 
https://code.engineering.redhat.com/gerrit/#/c/74341/
Comment 5 krishnaram Karthick 2016-05-31 09:01:00 UTC 
The issue reported in this bug is not seen in the logs of gluster version - glusterfs-3.7.9-6.el7rhgs.x86_64

Marking the bug as verified.
Comment 7 errata-xmlrpc 2016-06-23 05:22:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240