Bug 1336250

Summary: [RFE] The machine dialog format for hosted-engine-setup should set a flag if it's a field which should be masked
Product: [oVirt] otopi Reporter: Ryan Barry <rbarry>
Component: RFEsAssignee: Yedidyah Bar David <didi>
Status: CLOSED DUPLICATE QA Contact: meital avital <mavital>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: ---CC: bugs, dfediuck, didi, rbarry, ylavi
Target Milestone: ovirt-4.0.0-rcKeywords: FutureFeature
Target Release: ---Flags: ylavi: ovirt-4.0.0?
ylavi: exception?
ylavi: planning_ack+
sbonazzo: devel_ack+
rule-engine: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-26 07:15:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ryan Barry 2016-05-16 00:58:13 UTC
Description of problem:
Password input fields (for example) cannot be detected without a regular expression. otopi's machine dialect should output some flag for these fields, to be used by ovirt-hosted-engine-setup

Comment 1 Yaniv Lavi 2016-05-16 09:17:43 UTC
What is the impact on the current implementation?

Comment 2 Yedidyah Bar David 2016-05-16 09:28:54 UTC
(In reply to Yaniv Dary from comment #1)
> What is the impact on the current implementation?

Seems like Ryan currently works around it by checking the text for 'password', see line 120 of [1], which is the fix for bug 1334754.

[1] https://gerrit.ovirt.org/#/c/56371/4/dashboard/src/helpers/HostedEngineSetup.js

Comment 3 Yaniv Lavi 2016-05-25 12:39:11 UTC
Since we already have a fix for this and it is low risk for node and hosted engine setup, we will add it for 4.0.

Comment 4 Yedidyah Bar David 2016-05-26 07:15:27 UTC

*** This bug has been marked as a duplicate of bug 1337445 ***