Bug 1336250 - [RFE] The machine dialog format for hosted-engine-setup should set a flag if it's a field which should be masked
Summary: [RFE] The machine dialog format for hosted-engine-setup should set a flag if ...
Keywords:
Status: CLOSED DUPLICATE of bug 1337445
Alias: None
Product: otopi
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.0.0-rc
: ---
Assignee: Yedidyah Bar David
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-16 00:58 UTC by Ryan Barry
Modified: 2017-05-11 09:24 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-26 07:15:27 UTC
oVirt Team: Integration
Embargoed:
ylavi: ovirt-4.0.0?
ylavi: exception?
ylavi: planning_ack+
sbonazzo: devel_ack+
rule-engine: testing_ack?

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 56955 0 master MERGED machine_dialog: provide some metadata for queryString 2021-01-14 15:23:34 UTC

Description Ryan Barry 2016-05-16 00:58:13 UTC 
Description of problem:
Password input fields (for example) cannot be detected without a regular expression. otopi's machine dialect should output some flag for these fields, to be used by ovirt-hosted-engine-setup
Comment 1 Yaniv Lavi 2016-05-16 09:17:43 UTC 
What is the impact on the current implementation?
Comment 2 Yedidyah Bar David 2016-05-16 09:28:54 UTC 
(In reply to Yaniv Dary from comment #1)
> What is the impact on the current implementation?

Seems like Ryan currently works around it by checking the text for 'password', see line 120 of [1], which is the fix for bug 1334754.

[1] https://gerrit.ovirt.org/#/c/56371/4/dashboard/src/helpers/HostedEngineSetup.js
Comment 3 Yaniv Lavi 2016-05-25 12:39:11 UTC 
Since we already have a fix for this and it is low risk for node and hosted engine setup, we will add it for 4.0.
Comment 4 Yedidyah Bar David 2016-05-26 07:15:27 UTC 

*** This bug has been marked as a duplicate of bug 1337445 ***
Note You need to log in before you can comment on or make changes to this bug.