Bug 133713
Summary: | (firefox & thunderbird) remove or fix default app check | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> |
Component: | firefox | Assignee: | Christopher Aillon <caillon> |
Status: | CLOSED RAWHIDE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | barryn, k.georgiou, rvokal, tjb, wtogami |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-10-20 03:05:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 123268, 131589 |
Description
Bill Nottingham
2004-09-26 18:50:17 UTC
Totally in agreement. It should check and set "firefox %s" exactly as /usr/bin/gnome-default-applications-properties does so. This fixes the setting of the gconf keys, but I don't understand nsGNOMEShellService::IsDefaultBrowser() in nsGNOMEShellService.cpp where the checking part must also be fixed. --- mozilla/browser/components/shell/src/nsGNOMEShellService.cpp.orig 2004-10-06 18:20:53.279343935 -1000 +++ mozilla/browser/components/shell/src/nsGNOMEShellService.cpp 2004-10-06 18:21:25.317972727 -1000 @@ -228,7 +228,7 @@ nsCOMPtr<nsIGConfService> gconf = do_GetService(NS_GCONFSERVICE_CONTRACTID); nsCAutoString schemeList; - nsCAutoString appKeyValue(mAppPath + NS_LITERAL_CSTRING(" \"%s\"")); + nsCAutoString appKeyValue(NS_LITERAL_CSTRING("firefox %s")); unsigned int i; for (i = 0; i < NS_ARRAY_LENGTH(appProtocols); ++i) { It has no business even checking at all. https://bugzilla.mozilla.org/show_bug.cgi?id=263214 Ok, then the check should be removed from both firefox and thunderbird. *** Bug 135578 has been marked as a duplicate of this bug. *** I got this for firefox, and looks like blizzard nailed it for thunderbird. Marking RAWHIDE |