Bug 1337566

Summary:	Remove ImmDisableIME call without issues
Product:	Red Hat Enterprise Linux 7	Reporter:	Frediano Ziglio <fziglio>
Component:	virt-viewer	Assignee:	Virt Viewer Maint <virt-viewer-maint>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	dblechte, fidencio, fziglio, rbalakri
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Windows
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1342984 (view as bug list)		Environment:
Last Closed:	2016-06-06 09:34:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1342984

Description Frediano Ziglio 2016-05-19 13:25:30 UTC

Description of problem:
To solve some issue with Japanese keyboard and some IME settings ImmDisableIME is called. This however cause (on Windows 7) the keyboard taskbar applet to be hidden so user cannot easily change input method when virt-viewer is on focus.

Version-Release number of selected component (if applicable):
Last one with Japanese fixes.


How reproducible:
Always


Steps to Reproduce:
1. Use Windows 7 machine
2. Set a Japanese keyboard.
3. Install new virt-viewer.
4. Open a remote machine
5. Note that icon to change keyboard is hidden.


Actual results:
Icon get hidden


Expected results:
Icon visible, possible to switch IME/keyboard


Additional info:
One issue without ImmDisableIME is that pressing on the title of virt-viewer application with Hiragana input selected (as default and when the application is open) and start typing a new window get the keyboard input.
On other input methods (still with a Japanese keyboard) key events are not sent to the remote machine.
One possible solution would be to always hook and filter the keyboard at low level before Windows attempt to process IME inputs (so getting raw keystrokes).
Currently hook is installed only at some stricter condition and can be disabled.
in different ways.

Comment 2 Fabiano Fidêncio 2016-06-06 09:34:42 UTC

I can't  move this bug to the right component, as "A value must be set for the 'oVirt Team' field."

So, I've cloned the bug there and I'm closing it here.
For any further discussion, please, https://bugzilla.redhat.com/show_bug.cgi?id=1342984 is the proper place for it.