Bug 1342984 - virt-viewer: remove ImmDisableIME call without issues
Summary: virt-viewer: remove ImmDisableIME call without issues
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: mingw-virt-viewer
Version: unspecified
Hardware: Unspecified
OS: Windows
unspecified
unspecified
Target Milestone: ovirt-4.1.0-beta
: ---
Assignee: Default Assignee for SPICE Bugs
QA Contact: SPICE QE bug list
URL:
Whiteboard:
Depends On: 1337566
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-06 09:31 UTC by Fabiano Fidêncio
Modified: 2017-04-25 01:07 UTC (History)
15 users (show)

Fixed In Version: mingw-spice-gtk-0.31-6.el7ev mingw-virt-viewer-2.0-13.el7ev spice-client-msi-4.1-4
Doc Type: Bug Fix
Doc Text:
Previously, to support the Japanese keyboard, the Input Method Manager (IMM) was disabled and as a result users were unable to change the keyboard language. In this release, the Japanese keyboard is supported without disabling the IMM.
Clone Of: 1337566
Environment:
Last Closed:
oVirt Team: Spice
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Proposed additional patch ready to be imported into 4.1 (4.32 KB, patch)
2016-12-19 17:08 UTC, Frediano Ziglio 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1297640 0 high CLOSED Remote-viewer application unable to send some keys due to IME not disabled 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHBA-2017:1059 0 normal SHIPPED_LIVE spice-client-msi bug fix and enhancement update for RHV 4.1 2017-04-18 20:59:01 UTC

Internal Links: 1297640

Comment 1 Frediano Ziglio 2016-06-07 14:22:35 UTC 
Posted proposed patch for spice-gtk at https://lists.freedesktop.org/archives/spice-devel/2016-June/029946.html
Comment 2 Frediano Ziglio 2016-06-16 15:12:00 UTC 
Patches for spice-gtk acknowledged at https://lists.freedesktop.org/archives/spice-devel/2016-June/030290.html.

Proposed revert at https://lists.freedesktop.org/archives/spice-devel/2016-June/030296.html.
Comment 3 Frediano Ziglio 2016-06-16 15:41:00 UTC 
All patches merged (spice-gtk and virt-viewer).
Comment 6 Victor Toso 2016-12-19 14:57:22 UTC 
I'll be double checking the patches needed but if this might cause a regression as mentioned in [0] from comment #2 - we might need this bug to be fixed in 4.1

[0] https://lists.freedesktop.org/archives/spice-devel/2016-June/030296.html

PS: above patch is in mingw-virt-viwer 2.0-10
Comment 7 Victor Toso 2016-12-19 16:55:02 UTC 
mingw-spice-gtk:

* "Spice-widget: Use new gdk_event_get_scancode if available"
  f697933524b19186cb078b5fca43f748fd68cf9f

* "widget: Disable IME context on display widget"
  7d881d2193bf5598b888a48bb4d8d7ad2e62f443

Scratch build is fine:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253411

mingw-virt-viewer:

* "Revert "Disable IME to allow receiving all keys"
  18e0fa27e36cf6eb4764d1e3fa366c8de341b495

Scratch build is also fine:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253448

I'm giving this a Devel ACK - as per comment #6, we should have this on 4.1 to avoid the regression.
Comment 8 Frediano Ziglio 2016-12-19 17:07:16 UTC 
Would be great to add also 3e08aef2d30580b32e4024bcdc9d8a95dcccea87 ("widget: Do not ignore unsupported keys from keyboard").

Sequence to respect the order in master should be
* "Spice-widget: Use new gdk_event_get_scancode if available"
  f697933524b19186cb078b5fca43f748fd68cf9f

* "widget: Do not ignore unsupported keys from keyboard"
  3e08aef2d30580b32e4024bcdc9d8a95dcccea87
  
* "widget: Disable IME context on display widget"
  7d881d2193bf5598b888a48bb4d8d7ad2e62f443


Build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253446
Comment 9 Frediano Ziglio 2016-12-19 17:08:13 UTC 
Created attachment 1233431 [details]
Proposed additional patch ready to be imported into 4.1
Comment 11 Emma Heftman 2017-03-14 12:53:29 UTC 
Hi. Could you please set the requires_doc_text flag to - if no doc text is required, or ? if text should appear in the advisory. Then add the text to Doc Text field. Thanks.
Comment 12 Bill Sanford 2017-03-20 15:24:44 UTC 
Verified as Sanity Only.
Note You need to log in before you can comment on or make changes to this bug.