Bug 1341556

Summary:	[features/worm] Unwind FOPs with op_errno and add gf_worm prefix to functions
Product:	[Community] GlusterFS	Reporter:	Karthik U S <ksubrahm>
Component:	unclassified	Assignee:	Karthik U S <ksubrahm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs, josferna, jthottan, rtalur, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1333263	Environment:
Last Closed:	2016-06-16 12:33:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1333263
Bug Blocks:	1317278

Description Karthik U S 2016-06-01 09:43:40 UTC

+++ This bug was initially created as a clone of Bug #1333263 +++

Description of problem:

1.In the worm translator the FOPs are being unwinded using the errno -1. This should be replaced with the op_errno and assigning the proper error numbers to that.
2.Some of the functions in worm-helper.c should have gf_worm prefix so that they will not clash with any other functions.
The functions in worm.c should be static.

Version-Release number of selected component (if applicable):
Glsuterfs3.8.0




Additional info:
Requesting for review.

--- Additional comment from Vijay Bellur on 2016-05-05 03:18:01 EDT ---

REVIEW: http://review.gluster.org/14222 (unwinding FOPs with op_errno. Added gf_worm prefix to functions in worm-helper.c and made the functions static in worm.c.) posted (#1) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-12 03:17:28 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#2) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-25 06:55:21 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#3) for review on master by Niels de Vos (ndevos)

--- Additional comment from Vijay Bellur on 2016-05-26 04:28:10 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#4) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-26 14:53:20 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#5) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-27 08:16:33 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#6) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-30 09:29:20 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#7) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-05-31 11:56:00 EDT ---

COMMIT: http://review.gluster.org/14222 committed in master by Jeff Darcy (jdarcy) 
------
commit 03880f81dad9fd2a3a07c56a3cfbb994d44819b7
Author: karthik-us <ksubrahm>
Date:   Thu May 5 12:42:35 2016 +0530

    features/worm: updating function names & unwinding FOPs with op_errno
    
    - Added gf_worm prefix to some of the functions in worm-helper files so that
      they do not clash with other functions
    - Made the functions in worm.c static
    - Unwinding the FOPs with op_errno instead of using different unwind statements
    - Removed the multiple goto labels (wind & unwind)
    
    Change-Id: I3a2f114061aae4b422df54e91c4b3f702af5d0b0
    BUG: 1333263
    Signed-off-by: karthik-us <ksubrahm>
    Reviewed-on: http://review.gluster.org/14222
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Joseph Fernandes
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-06-01 10:07:46 UTC

REVIEW: http://review.gluster.org/14599 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#1) for review on release-3.8 by Karthik U S (ksubrahm)

Comment 2 Vijay Bellur 2016-06-01 10:20:10 UTC

REVIEW: http://review.gluster.org/14599 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#2) for review on release-3.8 by Karthik U S (ksubrahm)

Comment 3 Vijay Bellur 2016-06-01 11:39:29 UTC

REVIEW: http://review.gluster.org/14600 (features/worm: updating function names & unwinding FOPs with op_errno) posted (#1) for review on release-3.8 by Karthik U S (ksubrahm)

Comment 4 Vijay Bellur 2016-06-01 15:06:50 UTC

COMMIT: http://review.gluster.org/14600 committed in release-3.8 by Jeff Darcy (jdarcy) 
------
commit 6328ea45733852f299e4457bba97f632d8bada60
Author: karthik-us <ksubrahm>
Date:   Thu May 5 12:42:35 2016 +0530

    features/worm: updating function names & unwinding FOPs with op_errno
    
    - Added gf_worm prefix to some of the functions in worm-helper files so that
      they do not clash with other functions
    - Made the functions in worm.c static
    - Unwinding the FOPs with op_errno instead of using different unwind statements
    - Removed the multiple goto labels (wind & unwind)
    
    Backport of http://review.gluster.org/#/c/14222/
    
    > Change-Id: I3a2f114061aae4b422df54e91c4b3f702af5d0b0
    > BUG: 1333263
    > Signed-off-by: karthik-us <ksubrahm>
    > Reviewed-on: http://review.gluster.org/14222
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Joseph Fernandes
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: Ic94aebf3f0cb202a258a53f5c678430a15aeb557
    BUG: 1341556
    Signed-off-by: karthik-us <ksubrahm>
    Reviewed-on: http://review.gluster.org/14600
    Reviewed-by: Joseph Fernandes
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 5 Niels de Vos 2016-06-16 12:33:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user