Bug 1342984
| Summary: | virt-viewer: remove ImmDisableIME call without issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Fabiano Fidêncio <fidencio> | ||||
| Component: | mingw-virt-viewer | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> | ||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | bsanford, cfergeau, dblechte, eheftman, fidencio, gklein, lsurette, rbalakri, rh-spice-bugs, srevivo, tpelka, uril, victortoso, virt-bugs, virt-viewer-maint | ||||
| Target Milestone: | ovirt-4.1.0-beta | Keywords: | OtherQA | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Windows | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | mingw-spice-gtk-0.31-6.el7ev mingw-virt-viewer-2.0-13.el7ev spice-client-msi-4.1-4 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Previously, to support the Japanese keyboard, the Input Method Manager (IMM) was disabled and as a result users were unable to change the keyboard language. In this release, the Japanese keyboard is supported without disabling the IMM.
|
Story Points: | --- | ||||
| Clone Of: | 1337566 | Environment: | |||||
| Last Closed: | Type: | Bug | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Spice | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1337566 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Comment 1
Frediano Ziglio
2016-06-07 14:22:35 UTC
Patches for spice-gtk acknowledged at https://lists.freedesktop.org/archives/spice-devel/2016-June/030290.html. Proposed revert at https://lists.freedesktop.org/archives/spice-devel/2016-June/030296.html. All patches merged (spice-gtk and virt-viewer). I'll be double checking the patches needed but if this might cause a regression as mentioned in [0] from comment #2 - we might need this bug to be fixed in 4.1 [0] https://lists.freedesktop.org/archives/spice-devel/2016-June/030296.html PS: above patch is in mingw-virt-viwer 2.0-10 mingw-spice-gtk: * "Spice-widget: Use new gdk_event_get_scancode if available" f697933524b19186cb078b5fca43f748fd68cf9f * "widget: Disable IME context on display widget" 7d881d2193bf5598b888a48bb4d8d7ad2e62f443 Scratch build is fine: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253411 mingw-virt-viewer: * "Revert "Disable IME to allow receiving all keys" 18e0fa27e36cf6eb4764d1e3fa366c8de341b495 Scratch build is also fine: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253448 I'm giving this a Devel ACK - as per comment #6, we should have this on 4.1 to avoid the regression. Would be great to add also 3e08aef2d30580b32e4024bcdc9d8a95dcccea87 ("widget: Do not ignore unsupported keys from keyboard").
Sequence to respect the order in master should be
* "Spice-widget: Use new gdk_event_get_scancode if available"
f697933524b19186cb078b5fca43f748fd68cf9f
* "widget: Do not ignore unsupported keys from keyboard"
3e08aef2d30580b32e4024bcdc9d8a95dcccea87
* "widget: Disable IME context on display widget"
7d881d2193bf5598b888a48bb4d8d7ad2e62f443
Build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12253446
Created attachment 1233431 [details]
Proposed additional patch ready to be imported into 4.1
Hi. Could you please set the requires_doc_text flag to - if no doc text is required, or ? if text should appear in the advisory. Then add the text to Doc Text field. Thanks. Verified as Sanity Only. |