Bug 1345718

Summary:	warning messages seen in glusterd logs while setting the volume option
Product:	[Community] GlusterFS	Reporter:	Samikshan Bairagya <sbairagy>
Component:	glusterd	Assignee:	Gaurav Yadav <gyadav>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs, rhinduja, sasundar
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1326183	Environment:
Last Closed:	2017-01-23 11:05:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1420614, 1420987
Bug Blocks:

Description Samikshan Bairagya 2016-06-13 03:23:01 UTC

+++ This bug was initially created as a clone of Bug #1326183 +++

Description of problem:
-----------------------
Noticed the warning messages in glusterd logs after setting an volume option.
The warning message is as follows :
<snip>
[2016-04-11 16:48:34.823961] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]
[2016-04-11 16:48:34.824844] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]

</snip> 


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1.3 nightly build ( glusterfs-3.7.9-1.el7rhgs )

How reproducible:
------------------
consistent

Steps to Reproduce:
-------------------
1. Create any type of volume
2. Set any volume option on the volume
3. Observe glusterd logs

Actual results:
---------------
Warning messages seen in glusterd logs

Expected results:
-----------------
There shouldn't be any warning messages

--- Additional comment from SATHEESARAN on 2016-04-12 01:39:17 EDT ---

Below is the snip from Ravishankar ( AFR ) on this issue :

<snip>
Don't see any recent changes, but the builder (i.e. build_shd_graph()) is dict-getting a "graph-check" key from mod_dict and I see many places in the code where builders are launched via glusterd_create_global_volfile() with NULL dicts. So maybe a null check for dict in build_shd_graph() is sufficient.
</snip>

Comment 1 Gaurav Yadav 2017-01-23 11:05:54 UTC

I try recreating the issue but was not able to reproduce on my setup.
I have tested on master branch.

Reproduction Steps
1. Create Volume
2. Start Volume
3. Set properties
4. Observe glusterd logs

In logs I didn't see **[2016-04-11 16:48:34.823961] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]** warning.