Bug 1420987

+++ This bug was initially created as a clone of Bug #1420614 +++

+++ This bug was initially created as a clone of Bug #1326183 +++

Description of problem:
-----------------------
Noticed the warning messages in glusterd logs after setting an volume option.
The warning message is as follows :
<snip>
[2016-04-11 16:48:34.823961] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]
[2016-04-11 16:48:34.824844] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]

</snip> 


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1.3 nightly build ( glusterfs-3.7.9-1.el7rhgs )

How reproducible:
------------------
consistent

Steps to Reproduce:
-------------------
1. Create any type of volume
2. Set any volume option on the volume
3. Observe glusterd logs

Actual results:
---------------
Warning messages seen in glusterd logs

Expected results:
-----------------
There shouldn't be any warning messages

--- Additional comment from SATHEESARAN on 2016-04-12 01:39:17 EDT ---

Below is the snip from Ravishankar ( AFR ) on this issue :

<snip>
Don't see any recent changes, but the builder (i.e. build_shd_graph()) is dict-getting a "graph-check" key from mod_dict and I see many places in the code where builders are launched via glusterd_create_global_volfile() with NULL dicts. So maybe a null check for dict in build_shd_graph() is sufficient.
</snip>

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-07-04 04:53:14 EDT ---

This bug is automatically being proposed for the current z-stream release of Red Hat Gluster Storage 3 by setting the release flag 'rhgs‑3.1.z' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Rejy M Cyriac on 2016-09-17 12:34:39 EDT ---

Moving BZ to a transitional component in preparation for removing the 'glusterd' sub-component at the 'glusterd' component

--- Additional comment from Rejy M Cyriac on 2016-09-17 12:47:53 EDT ---

Moving BZ back to the 'glusterd' component after removal of the 'glusterd' sub-component

--- Additional comment from Worker Ant on 2017-02-09 00:00:23 EST ---

REVIEW: https://review.gluster.org/16573 (glusterd: put null check for mod_dict in build_shd_graph) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-02-09 11:19:47 EST ---

COMMIT: https://review.gluster.org/16573 committed in master by Jeff Darcy (jdarcy) 
------
commit 824a48fb5ce20e26ed78b26afd81ec876bc826ec
Author: Atin Mukherjee <amukherj>
Date:   Thu Feb 9 10:28:55 2017 +0530

    glusterd: put null check for mod_dict in build_shd_graph
    
    Change-Id: I849f5f7eb5932d2dc2a76f8abc61e41231f9883e
    BUG: 1420614
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/16573
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Smoke: Gluster Build System <jenkins.org>