+++ This bug was initially created as a clone of Bug #1326183 +++ Description of problem: ----------------------- Noticed the warning messages in glusterd logs after setting an volume option. The warning message is as follows : <snip> [2016-04-11 16:48:34.823961] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument] [2016-04-11 16:48:34.824844] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument] </snip> Version-Release number of selected component (if applicable): ------------------------------------------------------------- RHGS 3.1.3 nightly build ( glusterfs-3.7.9-1.el7rhgs ) How reproducible: ------------------ consistent Steps to Reproduce: ------------------- 1. Create any type of volume 2. Set any volume option on the volume 3. Observe glusterd logs Actual results: --------------- Warning messages seen in glusterd logs Expected results: ----------------- There shouldn't be any warning messages --- Additional comment from SATHEESARAN on 2016-04-12 01:39:17 EDT --- Below is the snip from Ravishankar ( AFR ) on this issue : <snip> Don't see any recent changes, but the builder (i.e. build_shd_graph()) is dict-getting a "graph-check" key from mod_dict and I see many places in the code where builders are launched via glusterd_create_global_volfile() with NULL dicts. So maybe a null check for dict in build_shd_graph() is sufficient. </snip>
I try recreating the issue but was not able to reproduce on my setup. I have tested on master branch. Reproduction Steps 1. Create Volume 2. Start Volume 3. Set properties 4. Observe glusterd logs In logs I didn't see **[2016-04-11 16:48:34.823961] W [dict.c:1452:dict_get_with_ref] (-->/usr/lib64/glusterfs/3.7.9/xlator/mgmt/glusterd.so(build_shd_graph+0x69) [0x7fdc0c3f3039] -->/lib64/libglusterfs.so.0(dict_get_str_boolean+0x32) [0x7fdc17830fe2] -->/lib64/libglusterfs.so.0(+0x1eba6) [0x7fdc1782eba6] ) 0-dict: dict OR key (graph-check) is NULL [Invalid argument]** warning.