Bug 1351933

Summary:	client ID should logged when SSL connection fails
Product:	[Community] GlusterFS	Reporter:	Mohit Agrawal <moagrawa>
Component:	protocol	Assignee:	Mohit Agrawal <moagrawa>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.12	CC:	annair, bugs, rabhat, rhs-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.15	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1333912	Environment:
Last Closed:	2016-09-01 09:20:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1333912, 1353429
Bug Blocks:	1351878

Description Mohit Agrawal 2016-07-01 08:12:12 UTC

+++ This bug was initially created as a clone of Bug #1333912 +++

+++ This bug was initially created as a clone of Bug #1333885 +++

Description of problem:

when a client tries to connect using SSl, and the connection fails, the client identifier (either IP address or the hostname) should be logged to help identify which client was attempting the connect.

[2016-04-04 13:06:57.982869] E [socket.c:352:ssl_setup_connection] 0-socket.management: SSL connect error
[2016-04-04 13:06:57.983084] E [socket.c:206:ssl_dump_error_stack] 0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number
[2016-04-04 13:06:57.983276] E [socket.c:2388:socket_poller] 0-socket.management: server setup failed
[2016-04-04 13:07:00.987987] E [socket.c:352:ssl_setup_connection] 0-socket.management: SSL connect error
[2016-04-04 13:07:00.988203] E [socket.c:206:ssl_dump_error_stack] 0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number

In the above logs ssl_setup_connection does not log the client identifier.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Raghavendra Bhat on 2016-05-06 12:13:51 EDT ---



--- Additional comment from Raghavendra Bhat on 2016-05-06 12:14:17 EDT ---



--- Additional comment from Vijay Bellur on 2016-05-06 12:16:03 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in ssl connect) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

--- Additional comment from Vijay Bellur on 2016-06-29 13:04:08 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in ssl connect) posted (#3) for review on master by Vijay Bellur (vbellur)

--- Additional comment from Vijay Bellur on 2016-06-30 18:24:23 EDT ---

COMMIT: http://review.gluster.org/14242 committed in master by Jeff Darcy (jdarcy) 
------
commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a
Author: Raghavendra Bhat <raghavendra>
Date:   Fri May 6 10:03:53 2016 -0400

    socket: log the client identifier in ssl connect
    
    Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
    BUG: 1333912
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/14242
    Tested-by: Vijay Bellur <vbellur>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Vijay Bellur 2016-07-01 08:23:34 UTC

REVIEW: http://review.gluster.org/14844 (socket: log the client identifier in ssl connect) posted (#1) for review on release-3.7 by MOHIT AGRAWAL (moagrawa)

Comment 2 Vijay Bellur 2016-07-16 07:34:40 UTC

REVIEW: http://review.gluster.org/14844 (socket: log the client identifier in ssl connect) posted (#2) for review on release-3.7 by MOHIT AGRAWAL (moagrawa)

Comment 3 Vijay Bellur 2016-08-04 05:10:29 UTC

COMMIT: http://review.gluster.org/14844 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit 2c97cac30a706fc3458ed557a9fe98b8d2d32ea9
Author: Raghavendra Bhat <raghavendra>
Date:   Fri May 6 10:03:53 2016 -0400

    socket: log the client identifier in ssl connect
    
    Backport of commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a
    
    > Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
    > BUG: 1333912
    > Signed-off-by: Raghavendra Bhat <raghavendra>
    > Reviewed-on: http://review.gluster.org/14242
    > Tested-by: Vijay Bellur <vbellur>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    > Smoke: Gluster Build System <jenkins.org>
    > (cherry picked from commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a)
    
    Change-Id: I2a57a206edab3e0c05ce28c299d78264c9a33d8b
    BUG: 1351933
    Signed-off-by: Mohit Agrawal <moagrawa>
    Reviewed-on: http://review.gluster.org/14844
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 4 Kaushal 2016-09-01 09:20:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report.

glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Kaushal 2016-09-01 09:32:51 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report.

glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html
[2] https://www.gluster.org/pipermail/gluster-users/