Bug 1353429 - client ID should logged when SSL connection fails
Summary: client ID should logged when SSL connection fails
Keywords:
Status: CLOSED DUPLICATE of bug 1351878
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mohit Agrawal
QA Contact:
URL:
Whiteboard:
Depends On: 1333885 1333912 1380275 1383879 1383882
Blocks: 1351878 1351933
TreeView+ depends on / blocked
 
Reported: 2016-07-07 04:35 UTC by Atin Mukherjee
Modified: 2019-11-14 08:37 UTC (History)
5 users (show)

Fixed In Version:
Clone Of: 1333912
Environment:
Last Closed: 2016-07-07 04:40:49 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2016-07-07 04:35:37 UTC
+++ This bug was initially created as a clone of Bug #1333912 +++

+++ This bug was initially created as a clone of Bug #1333885 +++

Description of problem:

when a client tries to connect using SSl, and the connection fails, the client identifier (either IP address or the hostname) should be logged to help identify which client was attempting the connect.

[2016-04-04 13:06:57.982869] E [socket.c:352:ssl_setup_connection] 0-socket.management: SSL connect error
[2016-04-04 13:06:57.983084] E [socket.c:206:ssl_dump_error_stack] 0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number
[2016-04-04 13:06:57.983276] E [socket.c:2388:socket_poller] 0-socket.management: server setup failed
[2016-04-04 13:07:00.987987] E [socket.c:352:ssl_setup_connection] 0-socket.management: SSL connect error
[2016-04-04 13:07:00.988203] E [socket.c:206:ssl_dump_error_stack] 0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number

In the above logs ssl_setup_connection does not log the client identifier.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Raghavendra Bhat on 2016-05-06 12:13:51 EDT ---



--- Additional comment from Raghavendra Bhat on 2016-05-06 12:14:17 EDT ---



--- Additional comment from Vijay Bellur on 2016-05-06 12:16:03 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in ssl connect) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

--- Additional comment from Vijay Bellur on 2016-06-29 13:04:08 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in ssl connect) posted (#3) for review on master by Vijay Bellur (vbellur)

--- Additional comment from Vijay Bellur on 2016-06-30 18:24:23 EDT ---

COMMIT: http://review.gluster.org/14242 committed in master by Jeff Darcy (jdarcy) 
------
commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a
Author: Raghavendra Bhat <raghavendra>
Date:   Fri May 6 10:03:53 2016 -0400

    socket: log the client identifier in ssl connect
    
    Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
    BUG: 1333912
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/14242
    Tested-by: Vijay Bellur <vbellur>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Atin Mukherjee 2016-07-07 04:40:49 UTC

*** This bug has been marked as a duplicate of bug 1351878 ***


Note You need to log in before you can comment on or make changes to this bug.