Bug 1352393

Summary:	[FEAT] DHT - rebalance - rebalance status o/p should be different for 'fix-layout' option, it should not show 'Rebalanced-files' , 'Size', 'Scanned' etc as it is not migrating any files.
Product:	[Community] GlusterFS	Reporter:	Sakshi <sabansal>
Component:	distribute	Assignee:	Sakshi <sabansal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs, kramdoss, mzywusko, nbalacha, racpatel, rhs-bugs, sankarshan, smohan, vbellur
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	dht-rebalance-usability
Fixed In Version:	glusterfs-3.8.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1225718	Environment:
Last Closed:	2016-07-08 14:42:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1225718
Bug Blocks:

Description Sakshi 2016-07-04 05:42:05 UTC

+++ This bug was initially created as a clone of Bug #1225718 +++

+++ This bug was initially created as a clone of Bug #890640 +++

Description of problem:
 rebalance - rebalance status o/p should be different for 'fix-layout' option, it should not show 'Rebalanced-files' , 'Size', 'Scanned' etc as it is not migrating any files. it should show status of layout fixing.

Version-Release number of selected component (if applicable):
3.3.0.5rhs-40

How reproducible:
always

Steps to Reproduce:
1. Create a Distributed volume having 3 or more sub-volumes on multiple server and start that volume.

2. Fuse Mount the volume from the client-1 using “mount -t glusterfs  server:/<volume> <client-1_mount_point>”

3. From mount point create some dirs and files inside it.

4. Execute rebalance.
[root@localhost ~]# gluster volume rebalance defect fix-layout start
Starting rebalance on volume defect has been successful

5. check status
[root@localhost ~]# gluster volume rebalance defect status
                                    Node Rebalanced-files          size       scanned      failures         status
                               ---------      -----------   -----------   -----------   -----------   ------------
                               localhost                0            0            0            0      completed
                            10.70.35.173                0            0            0            0      completed
                            10.70.35.170                0            0            0            0      completed

  
Actual results:
it shows 'Rebalanced-files' , 'Size', 'Scanned' etc

Expected results:
When user has opted only fix-layout this values will be zero and no use of showing those column in status. It can show no of dir for which layout has been fixed or it can show simply status column only.

Additional info:

--- Additional comment from Scott Haines on 2013-09-27 13:07:32 EDT ---

Targeting for 3.0.0 (Denali) release.

--- Additional comment from Vivek Agarwal on 2014-04-07 07:41:13 EDT ---

Per bug triage, between dev, PM and QA, moving these out of denali

--- Additional comment from Nagaprasad Sathyanarayana on 2014-05-06 06:35:12 EDT ---

BZs not targeted for Denali.

--- Additional comment from Anand Avati on 2015-05-28 02:01:03 EDT ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for 'fix-layout' option) posted (#1) for review on master by Sakshi Bansal (sabansal)

--- Additional comment from Anand Avati on 2015-09-01 08:37:11 EDT ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for 'fix-layout' option) posted (#4) for review on master by Sakshi Bansal (sabansal)

--- Additional comment from Vijay Bellur on 2016-01-14 02:45:26 EST ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for 'fix-layout' option) posted (#5) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-01-28 01:19:20 EST ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for fix-layout option) posted (#6) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-02-25 02:41:30 EST ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for fix-layout option) posted (#7) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-03-06 23:51:24 EST ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for rebalance fix-layout) posted (#8) for review on master by Sakshi Bansal

--- Additional comment from Mike McCune on 2016-03-28 19:31:34 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Vijay Bellur on 2016-04-07 02:39:14 EDT ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for rebalance fix-layout) posted (#9) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-04-12 01:20:17 EDT ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for rebalance fix-layout) posted (#10) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-04-18 11:48:28 EDT ---

REVIEW: http://review.gluster.org/10956 (cli: different status output for rebalance fix-layout) posted (#11) for review on master by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-07-04 01:39:21 EDT ---

COMMIT: http://review.gluster.org/10956 committed in master by Raghavendra G (rgowdapp) 
------
commit 1b420a3f695a755c6a45b3b74d28c41f7a2d943b
Author: Sakshi <sabansal>
Date:   Thu May 28 11:23:55 2015 +0530

    cli: different status output for rebalance fix-layout
    
    Change-Id: I6ded40a1b1cff5c72e5b61fd353db3d8c688efd8
    BUG: 1225718
    Signed-off-by: Sakshi <sabansal>
    Reviewed-on: http://review.gluster.org/10956
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 1 Vijay Bellur 2016-07-04 05:49:35 UTC

REVIEW: http://review.gluster.org/14851 (cli: different status output for rebalance fix-layout) posted (#1) for review on release-3.8 by Sakshi Bansal

Comment 2 Vijay Bellur 2016-07-05 04:29:11 UTC

COMMIT: http://review.gluster.org/14851 committed in release-3.8 by Raghavendra G (rgowdapp) 
------
commit 755b8c7e108a66211b876cf87a6f7fa244360b94
Author: Sakshi <sabansal>
Date:   Thu May 28 11:23:55 2015 +0530

    cli: different status output for rebalance fix-layout
    
    Backport of http://review.gluster.org/10956
    
    > Change-Id: I6ded40a1b1cff5c72e5b61fd353db3d8c688efd8
    > BUG: 1225718
    > Signed-off-by: Sakshi <sabansal>
    > Reviewed-on: http://review.gluster.org/10956
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Raghavendra G <rgowdapp>
    
    Change-Id: I6ded40a1b1cff5c72e5b61fd353db3d8c688efd8
    BUG: 1352393
    Signed-off-by: Sakshi <sabansal>
    Reviewed-on: http://review.gluster.org/14851
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Niels de Vos 2016-07-08 14:42:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.1, please open a new bug report.

glusterfs-3.8.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/156
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user